Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip --incompatible_existing_rules_immutable_view flag to true #14717

Conversation

tetromino
Copy link
Contributor

Fixes #13907

RELNOTES[INC]: The --incompatible_existing_rules_immutable_view flag has been
flipped to true. See #13907 for
migration notes.

Fixes bazelbuild#13907

RELNOTES[INC]: The --incompatible_existing_rules_immutable_view flag has been
flipped to true. See bazelbuild#13907 for
migration notes.
@tetromino
Copy link
Contributor Author

Running https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2349 to check if the flag flip breaks any rule sets

@comius comius assigned tetromino and unassigned comius Feb 8, 2022
@tetromino
Copy link
Contributor Author

Closed by 74b7dd5

@tetromino tetromino closed this Feb 8, 2022
@tetromino tetromino deleted the incompatible_existing_rules_immutable_view branch February 8, 2022 17:50
copybara-service bot pushed a commit that referenced this pull request Aug 17, 2024
…yard.

It has been enabled by default since Bazel 6.0 (#14717).

Removing the flag simplifies native.existing_rules() behavior considerably,
making it easier to add new finalizer macro semantics. Working towards
#23160

PiperOrigin-RevId: 663963764
Change-Id: I82308093cbf2f4befb53cd4ea19dfc75e14e19af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incompatible_existing_rules_immutable_view
3 participants