Collect coverage from cc_binary data deps of java_test #15216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Wyverald I tried to use |
fmeum
force-pushed
the
release-5.2.0-15096
branch
2 times, most recently
from
94aa451
to
3c56ba4
Compare
|
The CI failure is persistent, but looks quite unrelated. |
|
Hi @fmeum, Can you please check the buildkite presubmit failures. Thanks! |
Before this commit, if a java_test executed a cc_binary from its data deps, coverage for this cc_binary would not be collected. This is fixed by adding the implicit `$collect_cc_coverage` attribute to BazelJavaTestRule, similar to how this is already done for BazelShTestRule. Fixes the Java part of bazelbuild#15098. Closes bazelbuild#15096. PiperOrigin-RevId: 438785232
fmeum
force-pushed
the
release-5.2.0-15096
branch
from
3c56ba4
to
9d5afdd
Compare
|
@ckolli5 I don't see how the failing test would be related to this PR. Is it possible that this is an issue with the remote execution test setup? |
ckolli5
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, if a java_test executed a cc_binary from its data
deps, coverage for this cc_binary would not be collected. This is fixed
by adding the implicit
$collect_cc_coverageattribute toBazelJavaTestRule, similar to how this is already done for
BazelShTestRule.
Fixes the Java part of #15098.
Closes #15096.
PiperOrigin-RevId: 438785232
Fixes #15216