From 98b2cc810edfbec08ae00082b490895edef02318 Mon Sep 17 00:00:00 2001 From: Brentley Jones Date: Thu, 14 Mar 2024 11:12:10 -0500 Subject: [PATCH] Declare support for `gcc_quoting_for_param_files` feature in Unix cc_toolchain This was missed with a9e5a32b9c0de2ade15be67bd1b80c3ec8e6b472. Without this change, `gcc_quoting_for_param_files` does nothing. Without `gcc_quoting_for_param_files`, linking can fail for files with spaces in them. Signed-off-by: Brentley Jones --- tools/cpp/unix_cc_toolchain_config.bzl | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/cpp/unix_cc_toolchain_config.bzl b/tools/cpp/unix_cc_toolchain_config.bzl index 4273a2f93d0054..5060a97aa229a9 100644 --- a/tools/cpp/unix_cc_toolchain_config.bzl +++ b/tools/cpp/unix_cc_toolchain_config.bzl @@ -218,6 +218,11 @@ def _impl(ctx): enabled = True, ) + gcc_quoting_for_param_files_feature = feature( + name = "gcc_quoting_for_param_files", + enabled = True, + ) + static_link_cpp_runtimes_feature = feature( name = "static_link_cpp_runtimes", enabled = False, @@ -1399,6 +1404,7 @@ def _impl(ctx): asan_feature, tsan_feature, ubsan_feature, + gcc_quoting_for_param_files_feature, static_link_cpp_runtimes_feature, ] + ( [ @@ -1439,6 +1445,7 @@ def _impl(ctx): asan_feature, tsan_feature, ubsan_feature, + gcc_quoting_for_param_files_feature, static_link_cpp_runtimes_feature, ] + ( [