Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing info about downstream breakages for a new incompatible flag #631

Closed
brandjon opened this issue May 2, 2019 · 4 comments
Closed
Labels

Comments

@brandjon
Copy link
Member

brandjon commented May 2, 2019

In yesterday's bazelisk + incompatible change nightly, the flag --incompatible_use_python_toolchains is tested according to the logs of the builds, but it has no corresponding summary annotation telling me which projects failed the flag.

Is this because 0.25 was just released and the pipeline grabbed the list of flags in an inconsistent way? Does it have to do with the labels attached to the flag's migration bug?

@philwo
Copy link
Member

philwo commented May 3, 2019

@meteorcloudy @fweikert Any idea?

@meteorcloudy
Copy link
Member

The CI is somehow one step slower, the result is now in the latest run:
https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/99

@philwo
Copy link
Member

philwo commented May 28, 2019

Is this still an issue?

@meteorcloudy
Copy link
Member

I think it's fine to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants