From e9dd859e29d1a598cfcd90ffe71100b09a84f8b1 Mon Sep 17 00:00:00 2001 From: Borja Lorente Date: Tue, 19 Mar 2024 11:28:02 +0000 Subject: [PATCH] Address comments --- WORKSPACE.bzlmod | 2 ++ .../google/idea/blaze/aspect/go/go_proto_library/GoTest.java | 2 +- examples/go/with_proto/proto/translators.go | 3 ++- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/WORKSPACE.bzlmod b/WORKSPACE.bzlmod index e2fa3a6fb62..30daa46fcae 100644 --- a/WORKSPACE.bzlmod +++ b/WORKSPACE.bzlmod @@ -773,6 +773,8 @@ http_archive( load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies", "go_repository") +# gRPC is used to generate Go from proto in the aspect tests, in +# //aspect/testing/tests/src/com/google/idea/blaze/aspect/go/... go_repository( name = "org_golang_google_grpc", build_file_proto_mode = "disable", diff --git a/aspect/testing/tests/src/com/google/idea/blaze/aspect/go/go_proto_library/GoTest.java b/aspect/testing/tests/src/com/google/idea/blaze/aspect/go/go_proto_library/GoTest.java index f4d036dc15c..58358f81226 100644 --- a/aspect/testing/tests/src/com/google/idea/blaze/aspect/go/go_proto_library/GoTest.java +++ b/aspect/testing/tests/src/com/google/idea/blaze/aspect/go/go_proto_library/GoTest.java @@ -1,5 +1,5 @@ /* - * Copyright 2017 The Bazel Authors. All rights reserved. + * Copyright 2024 The Bazel Authors. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/examples/go/with_proto/proto/translators.go b/examples/go/with_proto/proto/translators.go index f79720cb504..b90b57db861 100644 --- a/examples/go/with_proto/proto/translators.go +++ b/examples/go/with_proto/proto/translators.go @@ -5,7 +5,8 @@ import ( ) // Time translation functions. - +// If all symbols resolve correctly (i.e. there are no red squigglies after a sync) +// then this target is working. func ToProtoTime(t time.Time) Time { return Time{Value: t.Format(time.RFC3339Nano)} }