From b92e1fce16c5da5130bc26a903148f17bf2eaf5c Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Fri, 5 Feb 2021 16:26:00 +0000 Subject: [PATCH 1/3] Add additional optional metadata fields --- .../remote/execution/v2/remote_execution.proto | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/build/bazel/remote/execution/v2/remote_execution.proto b/build/bazel/remote/execution/v2/remote_execution.proto index 9bb88a4a..6012509f 100644 --- a/build/bazel/remote/execution/v2/remote_execution.proto +++ b/build/bazel/remote/execution/v2/remote_execution.proto @@ -1690,4 +1690,21 @@ message RequestMetadata { // An identifier to tie multiple tool invocations together. For example, // runs of foo_test, bar_test and baz_test on a post-submit of a given patch. string correlated_invocations_id = 4; + + // A one-word description of the kind of action, for example, CppCompile or GoLink. + // There is no standard agreed set of values for this, and they are expected to vary between different client tools. + string action_mnemonic = 5; + + // A namespace within which the build was performed, for instance a repository/workspace name. + string invocation_namespace_id = 6; + + // An identifier for the target, unique within the invocation_namespace_id, which produced this action. + // No guarantees are made around how many actions may relate to a single target. + string target = 7; + + // An identifier for the configuration in which the target was built, + // e.g. for differentiating building host tools or different target platforms. + // There is no expectation that this value will have any particular structure, + // or equality across invocations, though some client tools may offer these guarantees. + string configuration_id = 8; } From fce5dcbc3f5ee8ba45452913a821243c1e97351c Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Mon, 15 Feb 2021 16:58:42 +0000 Subject: [PATCH 2/3] Add comment about namespace non-global-uniqueness --- build/bazel/remote/execution/v2/remote_execution.proto | 1 + 1 file changed, 1 insertion(+) diff --git a/build/bazel/remote/execution/v2/remote_execution.proto b/build/bazel/remote/execution/v2/remote_execution.proto index 6012509f..79a1afb2 100644 --- a/build/bazel/remote/execution/v2/remote_execution.proto +++ b/build/bazel/remote/execution/v2/remote_execution.proto @@ -1696,6 +1696,7 @@ message RequestMetadata { string action_mnemonic = 5; // A namespace within which the build was performed, for instance a repository/workspace name. + // There are no guarantees that these are globally unique, e.g. two users may create namespaces with the same name. string invocation_namespace_id = 6; // An identifier for the target, unique within the invocation_namespace_id, which produced this action. From 7783dd9a52be4326e58ee8843ffeac40c30dc0d9 Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Wed, 24 Feb 2021 21:08:59 +0000 Subject: [PATCH 3/3] Remove workspace for now --- .../bazel/remote/execution/v2/remote_execution.proto | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/build/bazel/remote/execution/v2/remote_execution.proto b/build/bazel/remote/execution/v2/remote_execution.proto index 79a1afb2..848c7a48 100644 --- a/build/bazel/remote/execution/v2/remote_execution.proto +++ b/build/bazel/remote/execution/v2/remote_execution.proto @@ -1691,21 +1691,17 @@ message RequestMetadata { // runs of foo_test, bar_test and baz_test on a post-submit of a given patch. string correlated_invocations_id = 4; - // A one-word description of the kind of action, for example, CppCompile or GoLink. + // A brief description of the kind of action, for example, CppCompile or GoLink. // There is no standard agreed set of values for this, and they are expected to vary between different client tools. string action_mnemonic = 5; - // A namespace within which the build was performed, for instance a repository/workspace name. - // There are no guarantees that these are globally unique, e.g. two users may create namespaces with the same name. - string invocation_namespace_id = 6; - - // An identifier for the target, unique within the invocation_namespace_id, which produced this action. + // An identifier for the target which produced this action. // No guarantees are made around how many actions may relate to a single target. - string target = 7; + string target_id = 6; // An identifier for the configuration in which the target was built, // e.g. for differentiating building host tools or different target platforms. // There is no expectation that this value will have any particular structure, // or equality across invocations, though some client tools may offer these guarantees. - string configuration_id = 8; + string configuration_id = 7; }