Filter out -lstdc++ for targets with no C++ code #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids an unnecessary run-time dependency on libstdc++.so, which may not be present in container environments. go build only adds this dependency if C++ code is included in the build. We now filter out this dependency from the cc toolchain flags unless we have C++/ObjC source or we have a dependency on a cc_library or objc_library. Fixes bazel-contrib#1681 Related bazelbuild/bazel#2954
jayconrod
added a commit
that referenced
this pull request
Sep 5, 2018
This avoids an unnecessary run-time dependency on libstdc++.so, which may not be present in container environments. go build only adds this dependency if C++ code is included in the build. We now filter out this dependency from the cc toolchain flags unless we have C++/ObjC source or we have a dependency on a cc_library or objc_library. Fixes #1681 Related bazelbuild/bazel#2954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids an unnecessary run-time dependency on libstdc++.so, which
may not be present in container environments.
go build only adds this dependency if C++ code is included in the
build. We now filter out this dependency from the cc toolchain flags
unless we have C++/ObjC source or we have a dependency on a cc_library
or objc_library.
Fixes #1681
Related bazelbuild/bazel#2954