fix: remove --keep-names

This option injects a `defineProperty` to existing function to keep its names for debugging purposes. ```js function foo () {} Object.defineProperty(foo, 'name', {value: 'foo'}) ``` This however breaks older browsers since you cannot re-define a function name.
bazel-contrib · Feb 23, 2021 · 4a26898 · 4a26898
1 parent 9506fe0
commit 4a26898
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 1 deletion.
diff --git a/packages/esbuild/esbuild.bzl b/packages/esbuild/esbuild.bzl
@@ -55,7 +55,6 @@ def _esbuild_impl(ctx):
 
     args.add("--bundle", entry_point.path)
     args.add("--sourcemap")
-    args.add("--keep-names")
     args.add("--preserve-symlinks")
     args.add_joined(["--platform", ctx.attr.platform], join_with = "=")
     args.add_joined(["--target", ctx.attr.target], join_with = "=")

diff --git a/packages/esbuild/test/alias-mapping/BUILD.bazel b/packages/esbuild/test/alias-mapping/BUILD.bazel
@@ -3,6 +3,7 @@ load("//packages/esbuild/test:tests.bzl", "esbuild")
 
 esbuild(
     name = "bundle",
+    args = ["--keep-names"],
     entry_point = "main.js",
     format = "esm",
     deps = [

diff --git a/packages/esbuild/test/bundle/BUILD.bazel b/packages/esbuild/test/bundle/BUILD.bazel
@@ -16,19 +16,22 @@ ts_library(
 
 esbuild(
     name = "bundle",
+    args = ["--keep-names"],
     entry_point = "a.ts",
     deps = [":lib"],
 )
 
 esbuild(
     name = "bundle.min",
+    args = ["--keep-names"],
     entry_point = "a.ts",
     minify = True,
     deps = [":lib"],
 )
 
 esbuild(
     name = "bundle.split",
+    args = ["--keep-names"],
     entry_point = "a.ts",
     output_dir = True,
     deps = [":lib"],

diff --git a/packages/esbuild/test/define/BUILD.bazel b/packages/esbuild/test/define/BUILD.bazel
@@ -14,6 +14,7 @@ ts_library(
 
 esbuild(
     name = "bundle",
+    args = ["--keep-names"],
     define = [
         "process.env.NODE_ENV=\"defined_in_bundle\"",
     ],

diff --git a/packages/esbuild/test/external-flag/BUILD.bazel b/packages/esbuild/test/external-flag/BUILD.bazel
@@ -14,6 +14,7 @@ ts_library(
 
 esbuild(
     name = "bundle",
+    args = ["--keep-names"],
     entry_point = "main.ts",
     external = [
         "fs",

diff --git a/packages/esbuild/test/splitting/BUILD.bazel b/packages/esbuild/test/splitting/BUILD.bazel
@@ -16,6 +16,7 @@ ts_library(
 
 esbuild(
     name = "bundle",
+    args = ["--keep-names"],
     entry_point = "main.ts",
     output_dir = True,
     deps = [":main"],

diff --git a/packages/esbuild/test/typescript/BUILD.bazel b/packages/esbuild/test/typescript/BUILD.bazel
@@ -19,6 +19,7 @@ ts_library(
 
 esbuild(
     name = "bundle",
+    args = ["--keep-names"],
     entry_point = "main.ts",
     format = "esm",
     deps = [":main"],

diff --git a/packages/esbuild/test/workspace-mapping/BUILD.bazel b/packages/esbuild/test/workspace-mapping/BUILD.bazel
@@ -3,6 +3,7 @@ load("//packages/esbuild/test:tests.bzl", "esbuild")
 
 esbuild(
     name = "bundle",
+    args = ["--keep-names"],
     entry_point = "main.js",
     format = "esm",
     link_workspace_root = True,