fix: turn off preserve_symlinks in e2e/node_loader_no_preserve_symlin…

…ks test
bazel-contrib · Jan 11, 2022 · 5410ab2 · 5410ab2
1 parent abdf05b
commit 5410ab2
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 11 deletions.
diff --git a/docs/Built-ins.md b/docs/Built-ins.md
@@ -23,7 +23,7 @@ nodejs_binary(<a href="#nodejs_binary-name">name</a>, <a href="#nodejs_binary-ch
 </pre>
 
 Runs some JavaScript code in NodeJS. You can also change the default args that are sent to nodejs. This can be done through a flag. The default is --preserve-symlinks while anything
-can be passed. The flag is --@build_bazel_rules_nodejs//nodejs:default_args="" ex: bazel build --@build_bazel_rules_nodejs//nodejs:default_args="--preserve-symlinks --no-warnings" main
+can be passed. The flag is --@rules_nodejs//nodejs:default_args="" ex: bazel build --@rules_nodejs//nodejs:default_args="--preserve-symlinks --no-warnings" //:target.
 This will pass --preserve-symlinks and --no-warnings flags to nodejs. Available node flags can be found here: https://nodejs.org/api/cli.html.
 
 **ATTRIBUTES**
@@ -280,7 +280,7 @@ The runtime will pause before executing the program, allowing you to connect a
 remote debugger.
 
 You can also change the default args that are sent to nodejs. This can be done through a flag. The default is --preserve-symlinks while anything
-can be passed. The flag is --@build_bazel_rules_nodejs//nodejs:default_args="" ex: bazel test --@build_bazel_rules_nodejs//nodejs:default_args="--preserve-symlinks --no-warnings" main
+can be passed. The flag is --@rules_nodejs//nodejs:default_args="" ex: bazel test --@rules_nodejs//nodejs:default_args="--preserve-symlinks --no-warnings" //:target.
 This will pass --preserve-symlinks and --no-warnings flags to nodejs. Available node flags can be found here: https://nodejs.org/api/cli.html.
 
 

diff --git a/docs/Cypress.md b/docs/Cypress.md
@@ -157,7 +157,7 @@ The runtime will pause before executing the program, allowing you to connect a
 remote debugger.
 
 You can also change the default args that are sent to nodejs. This can be done through a flag. The default is --preserve-symlinks while anything
-can be passed. The flag is --@build_bazel_rules_nodejs//nodejs:default_args="" ex: bazel test --@build_bazel_rules_nodejs//nodejs:default_args="--preserve-symlinks --no-warnings" main
+can be passed. The flag is --@rules_nodejs//nodejs:default_args="" ex: bazel test --@rules_nodejs//nodejs:default_args="--preserve-symlinks --no-warnings" //:target.
 This will pass --preserve-symlinks and --no-warnings flags to nodejs. Available node flags can be found here: https://nodejs.org/api/cli.html.
 
 

diff --git a/e2e/node_loader_no_preserve_symlinks/.bazelrc b/e2e/node_loader_no_preserve_symlinks/.bazelrc
@@ -1 +1,3 @@
 import %workspace%/../../common.bazelrc
+
+build --@rules_nodejs//nodejs:default_args=""
diff --git a/internal/node/node.bzl b/internal/node/node.bzl
@@ -630,7 +630,7 @@ _NODEJS_EXECUTABLE_OUTPUTS = {
 nodejs_binary_kwargs = {
     "attrs": _NODEJS_EXECUTABLE_ATTRS,
     "doc": """Runs some JavaScript code in NodeJS. You can also change the default args that are sent to nodejs. This can be done through a flag. The default is --preserve-symlinks while anything
-can be passed. The flag is --@build_bazel_rules_nodejs//nodejs:default_args="" ex: bazel build --@build_bazel_rules_nodejs//nodejs:default_args="--preserve-symlinks --no-warnings" main
+can be passed. The flag is --@rules_nodejs//nodejs:default_args="" ex: bazel build --@rules_nodejs//nodejs:default_args="--preserve-symlinks --no-warnings" //:target.
 This will pass --preserve-symlinks and --no-warnings flags to nodejs. Available node flags can be found here: https://nodejs.org/api/cli.html.""",
     "executable": True,
     "implementation": _nodejs_binary_impl,
@@ -696,7 +696,7 @@ The runtime will pause before executing the program, allowing you to connect a
 remote debugger.
 
 You can also change the default args that are sent to nodejs. This can be done through a flag. The default is --preserve-symlinks while anything
-can be passed. The flag is --@build_bazel_rules_nodejs//nodejs:default_args="" ex: bazel test --@build_bazel_rules_nodejs//nodejs:default_args="--preserve-symlinks --no-warnings" main
+can be passed. The flag is --@rules_nodejs//nodejs:default_args="" ex: bazel test --@rules_nodejs//nodejs:default_args="--preserve-symlinks --no-warnings" //:target.
 This will pass --preserve-symlinks and --no-warnings flags to nodejs. Available node flags can be found here: https://nodejs.org/api/cli.html.
 """,
     test = True,

diff --git a/nodejs/BUILD.bazel b/nodejs/BUILD.bazel
@@ -39,12 +39,9 @@ toolchain_type(
     for key, values in PLATFORMS.items()
 ]
 
-# User set flags that are passed to the build
-# you need to make sure that you pass the correct repo name infront for this flag to work
-# if you are using rules from build_bazel_rules_nodejs that should be the @ in the flag
-# ex: bazel build --@build_bazel_rules_nodejs//nodejs:default_args="test" main
-# use rules_nodejs when you use things from that repo
-# bazel test --//nodejs:default_args="" //...
+# Default arguments/flags that are passed to nodejs in all nodejs_binary and
+# nodejs_test targets. Can be overwritten by settings
+# --@rules_nodejs//nodejs:default_args="--flag1 --flag2"
 user_args(
     name = "default_args",
     build_setting_default = "--preserve-symlinks",