Skip to content

Commit

Permalink
fix(typescript): add .proto files from npm deps to inputs of ts_libra…
Browse files Browse the repository at this point in the history
…ry (#1991)

If @bazel/typescript is a dep of ts_library then the linker needs to include 'third_party/github.com/bazelbuild/bazel/src/main/protobuf/worker_protocol.proto' as an input as worker.js will run out of node_modules. The failure was only observed on Angular repo RBE since running ts_library has workers on by default it is not sandboxed.
  • Loading branch information
gregmagolan authored Jul 1, 2020
1 parent becd9bc commit c1d4885
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/typescript/internal/build_defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def _filter_ts_inputs(all_inputs):
return [
f
for f in all_inputs
if f.extension in ["js", "jsx", "ts", "tsx", "json"]
if f.extension in ["js", "jsx", "ts", "tsx", "json", "proto"]
]

def _compile_action(ctx, inputs, outputs, tsconfig_file, node_opts, description = "prodmode"):
Expand Down

0 comments on commit c1d4885

Please sign in to comment.