feat: node-patches\filesystem patcher. #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrems
reviewed
Nov 4, 2019
Toxicable
reviewed
Nov 5, 2019
gregmagolan
reviewed
Nov 8, 2019
mrmeku
reviewed
Nov 8, 2019
mrmeku
reviewed
Nov 8, 2019
soldair
force-pushed
the
symlink-patcher
branch
from
2fb38c5
to
fd25fb9
Compare
gregmagolan
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
LGTM.
The npm_packages and associated node_patches target can go in a follow up PR as they are not being used and we should integrate the testing into the bazel in a follow PR as well and use the "checked-in file" rule to ensure the check-in js files up to date.
as integration will happen in another pr.
This reverts commit 9795e68.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new package which patches the fs module of node core such that it will not follow links out of a root directory path.
for the nodejs startup script. prevents links from escaping the sandbox