feat: add support for NodeJS 15.x #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mattem
force-pushed
the
feat/node15
branch
5 times, most recently
from
5b26b85
to
006ded0
Compare
mattem
force-pushed
the
feat/node15
branch
7 times, most recently
from
fc57b7a
to
39d6147
Compare
mattem
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
Include support for NodeJS 15.x, updates some examples to use this Switches bazel-in-bazel example tests to use a tar file for package.json replacements
alexeagle
approved these changes
Jan 24, 2021
There was a problem hiding this comment.
sweet! I think this unblocks some other fix that was tripping over our npm package overrides in the integration test - something about a workaround...
Ah yes, I think we could un-hack here:
b6a8cbb#diff-da7e70fd50ce8f04f6ac7d53c8a254acfabac83a73dc10a6c16dfe81875b563f
(and the corresponding one for npm ci 1d650fb#diff-da7e70fd50ce8f04f6ac7d53c8a254acfabac83a73dc10a6c16dfe81875b563fR229
)
maybe as a follow-up cleanup tho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for NodeJS ^15.0.0
Main issue was captured in npm/cli#2145, due to a breaking change in how npm handles transitive node_modules of file linked paths.
The included change here generates a tar file for the package and replaces the file path to the tar into the
package.jsonunder test.closes #2339
closes #2256