fix: remove mirror.bazel.build from list of node_urls used to fetch NodeJS by default #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattem
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
alexeagle
approved these changes
Jan 20, 2021
mattem
force-pushed
the
fix/remove-bazel-mirror
branch
from
613344a
to
13609d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
mirror.bazel.buildfrom the list of defaultnode_urlsused when fetching NodeJS. We don't control the bazel.build mirror, and don't think the responsibility sits with the bazel team to mirror these packages.closes #2406