fix(examples): transpile Angular es5 bundle to SystemJS #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the es5 bundle created with Babel is transpiled to use require for loading modules. This does not work with SystemJS, which is used in the Angular example. This PR changes the transpilation to SystemJS.
kyubisation
requested review from
alan-agius4,
alexeagle,
gregmagolan and
mattem
as code owners
alexeagle
approved these changes
Apr 20, 2021
twheys
pushed a commit
to twheys/rules_nodejs
that referenced
this pull request
Jan 13, 2022
…b#2562) By default the es5 bundle created with Babel is transpiled to use require for loading modules. This does not work with SystemJS, which is used in the Angular example. This PR changes the transpilation to SystemJS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the es5 bundle created with Babel is transpiled to use require
for loading modules. This does not work with SystemJS, which is used in the
Angular example. This PR changes the transpilation to SystemJS.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1869
What is the new behavior?
Does this PR introduce a breaking change?
Other information