Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make generated_file_test .update's visibility same as test rule #2677

Merged
merged 3 commits into from
May 17, 2021
Merged

fix: make generated_file_test .update's visibility same as test rule #2677

merged 3 commits into from
May 17, 2021

Conversation

longlho
Copy link
Contributor

@longlho longlho commented May 17, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label May 17, 2021
@alexeagle alexeagle merged commit 30bc86c into bazel-contrib:stable May 17, 2021
@longlho longlho deleted the patch-1 branch May 17, 2021 20:40
alexeagle pushed a commit that referenced this pull request May 26, 2021
@longlho @alexeagle
fix: make generated_file_test .update's visibility same as test rule (
1ce9dce 
#2677)
twheys pushed a commit to twheys/rules_nodejs that referenced this pull request Jan 13, 2022
@longlho @twheys
fix: make generated_file_test .update's visibility same as test rule (
e4f3505 
bazel-contrib#2677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan gregmagolan is a code owner

@mattem mattem Awaiting requested review from mattem mattem is a code owner

@soldair soldair Awaiting requested review from soldair

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@longlho @alexeagle