Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builtin): add support for using a local .nvmrc file for providing a node version #2911

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

josephperrott
Copy link
Collaborator

Add use_nvmrc attribute on node_repositories to provide a Label pointing to the local .nvmrc file in the repository.

…g a node version

Add `use_nvmrc` attribute on `node_repositories` to provide a Label pointing to the
local .nvmrc file in the repository.
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat idea! thanks :)
only thing I'd wish for is a link to learn more about nvm in case a user is reading about this option but doesn't already know what that file does

@alexeagle alexeagle merged commit 44740df into bazel-contrib:stable Sep 9, 2021
@josephperrott josephperrott deleted the use-nvmrc branch September 9, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants