feat(typescript): support for ESM variant of the Angular compiler plugin #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
force-pushed
the
feat/support-for-v13-angular-compiler
branch
from
d459ac9
to
24b7a10
Compare
As of v13, the `@angular/compiler-cli` package will come as strict ESM package. This means that the import currently in `tsc_wrapped` does not work for v13+ of Angular. This commit adds an interop allowing for both the ESM variant, and CJS variant of the Angular compiler to work.
devversion
force-pushed
the
feat/support-for-v13-angular-compiler
branch
from
24b7a10
to
1bd3de1
Compare
devversion
requested review from
alexeagle,
gregmagolan,
mattem and
soldair
as code owners
alexeagle
approved these changes
Sep 27, 2021
| @@ -61,6 +61,7 @@ tsc( | |||
| data = _TSC_WRAPPED_SRCS + [ | |||
| "//internal:tsconfig.json", | |||
| "@npm//@types/node", | |||
| "@npm//@angular/compiler-cli", | |||
There was a problem hiding this comment.
it feels a bit undesirable to have a compile-time dependency, but it does reflect the actual types of the tsc_wrapped program where we added the layering violation
There was a problem hiding this comment.
It's only compiled when tsc_wrapped is built as part of the @bazel/typescript NPM package, so it doesn't have any impact on consumers. The benefit is just a little type-safety here, compared to relying onany
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v13, the
@angular/compiler-clipackage will come as strict ESMpackage. This means that the import currently in
tsc_wrappeddoesnot work for v13+ of Angular. This commit adds an interop allowing for
both the ESM variant, and CJS variant of the Angular compiler to work.