fix(builtin): yarn_install with vendored yarn .cjs file breaks
#3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added a commit
to devversion/dev-infra
that referenced
this pull request
Mar 1, 2022
More details here: bazel-contrib/rules_nodejs#3350. This commit adds a little wrapper script as temporary workaround to fix CI.
`yarn_install` allows for a vendored/custom Yarn JavaScript file. To ensure that Yarn runs with the proper Node version, `yarn_install` calls the JS file with the host NodeJS version also installed through Bazel. Currently the detection logic does not account for `.cjs` or `.mjs`. This is a little confusing as the install continues to work but breaks surprisingly in Windows then, or when a engines requirement is no longer satisifed (there are more reasons as well) We should support `cjs` and `mjs` to avoid confusion, and especially `cjs` since Yarn itself always vendors itself with that extension!
devversion
force-pushed
the
fix-yarn-vendored-cjs
branch
from
51fed6b
to
51e33fc
Compare
devversion
requested review from
mattem,
gregmagolan and
alexeagle
as code owners
devversion
added a commit
to angular/dev-infra
that referenced
this pull request
Mar 1, 2022
More details here: bazel-contrib/rules_nodejs#3350. This commit adds a little wrapper script as temporary workaround to fix CI.
alexeagle
approved these changes
Mar 1, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn_installallows for a vendored/custom Yarn JavaScript file. To ensurethat Yarn runs with the proper Node version,
yarn_installcalls the JS filewith the host NodeJS version also installed through Bazel. Currently the detection
logic does not account for
.cjsor.mjs. This is a little confusing as theinstall continues to work but breaks surprisingly in Windows then, or when a engines
requirement is no longer satisifed (there are more reasons as well)
We should support
cjsandmjsto avoid confusion, and especiallycjssince Yarn itself always vendors itself with that extension!
Fixes #3349