Finish removal of builtin jasmine_node_test #838
Comments
alexeagle
added a commit
to alexeagle/rules_nodejs
that referenced
this issue
Jul 26, 2019
alexeagle
added a commit
to alexeagle/rules_nodejs
that referenced
this issue
Jul 26, 2019
alexeagle
added a commit
to alexeagle/rules_nodejs
that referenced
this issue
Jul 27, 2019
BREAKING CHANGE:
You can no longer get jasmine_node_test from @build_bazel_rules_nodejs.
- Use `load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")`
instead
- You need to remove `@npm//jasmine` from the deps of the
jasmine_node_test
- If you use user-managed dependencies, see the commit for examples of
the change needed
Also makes the repo bazel-lint-clean, so running yarn bazel:lint-fix no
longer makes edits.
Fixes bazel-contrib#838
alexeagle
added a commit
to alexeagle/rules_nodejs
that referenced
this issue
Jul 27, 2019
BREAKING CHANGE:
You can no longer get jasmine_node_test from @build_bazel_rules_nodejs.
- Use `load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")`
instead
- You need to remove `@npm//jasmine` from the deps of the
jasmine_node_test
- If you use user-managed dependencies, see the commit for examples of
the change needed
Also makes the repo bazel-lint-clean, so running yarn bazel:lint-fix no
longer makes edits.
Fixes bazel-contrib#838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We moved to
@bazel/jasmineand have been printing a warning. Before 1.0 we should remove the old one. Still see a bunch of warnings within our own repo.note, this is a pain to do with our current mechanism for how each package/ depends on the others. Would like to get to a simpler monorepo setup where everything is a source dependency first.
The text was updated successfully, but these errors were encountered: