Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repositories generated by pip_parse contain a BUILD and a BUILD.bazel #440

Closed
person142 opened this issue Mar 26, 2021 · 0 comments · Fixed by #457
Closed

Repositories generated by pip_parse contain a BUILD and a BUILD.bazel #440

person142 opened this issue Mar 26, 2021 · 0 comments · Fixed by #457

Comments

@person142
Copy link
Contributor

Affected Rule

pip_parse

Is this a regression?

No

Description

The repositories generated by pip_parse contain a BUILD file and a BUILD.bazel file; the former shouldn't be there. For example lsing the contents of an attrs repository gives:

BUILD
BUILD.bazel
WORKSPACE
attr
attrs-20.3.0.dist-info

In addition, the BUILD.bazel file doesn't exclude the BUILD file in the glob (only the BUILD.bazel), so it gets injected into the built artifacts.

🔬 Minimal Reproduction

Inspect the contents of a repository generated by pip_parse.

🔥 Exception or Error

None

🌍 Your Environment

Operating System:

Seen on both Linux/macOS

Output of bazel version:

$ bazelisk version
Bazelisk version: v1.5.0
Build label: 3.3.1
Build target: bazel-out/darwin-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Tue Jun 30 15:14:05 2020 (1593530045)
Build timestamp: 1593530045
Build timestamp as int: 1593530045

Rules_python version:

7aaf7627485c84c4ecd976f7b3fa940f60bb007c

Anything else relevant?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant