Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there is a vendored in version of skylib under third_party #667

Closed
aiuto opened this issue Mar 21, 2022 · 3 comments
Closed

there is a vendored in version of skylib under third_party #667

aiuto opened this issue Mar 21, 2022 · 3 comments
Labels
cleanup Tech debt, resolving it improves our own velocity

Comments

@aiuto
Copy link
Contributor

aiuto commented Mar 21, 2022

That's just an anti-pattern. We should use the real one, or recreate the few needed features and not call it skylib.

@aiuto aiuto added the cleanup Tech debt, resolving it improves our own velocity label Mar 21, 2022
@alexeagle
Copy link
Collaborator

We did this because bzlmod isn't a thing yet, and didn't want to make a breaking change where we require users to install some rules_python dependencies because rules_python is so foundational and users easily get a skewed version of bazel_skylib if we depended on one.
I don't really agree it's an antipattern. I think core rulesets should just ship with zero dependencies until most users are on bzlmod.

@johnynek
Copy link
Member

The old "the old thing is deprecated and the new thing is not ready yet".

@alexeagle
Copy link
Collaborator

Obviously the other problem is that skylib wasn't accepting contributions for many months, so like other users we had to fork.

@groodt groodt added the Can Close? Will close in 30 days if there is no new activity label Jan 10, 2023
@github-actions github-actions bot removed the Can Close? Will close in 30 days if there is no new activity label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Development

No branches or pull requests

4 participants