Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py_wheel#requires - Substitute/stamp info #997

Closed
jgsogo opened this issue Jan 19, 2023 · 4 comments
Closed

py_wheel#requires - Substitute/stamp info #997

jgsogo opened this issue Jan 19, 2023 · 4 comments
Labels
Can Close? Will close in 30 days if there is no new activity

Comments

@jgsogo
Copy link

jgsogo commented Jan 19, 2023

🚀 Support stamping in requires and extra_requires

Relevant Rules

py_wheel

Description

On py_wheel rule I would like to be able to stamp bazel provided variables:

py_wheel(
    ... 
    requires = [
        "{SOME_DEP_AND_VERSION}",
        "req1~={REQ1_VERSION}",
    ],
    extra_requires = {
        "feature": [
            "opt_req~={OPT_REQ_VERSION}",
        ]
    },
    ...
)

Currently no replacement is done on those strings, they are just used as a string_list.

Describe the solution you'd like

The generated wheel should contain the requirement list resulting from the replacement.

@alexeagle
Copy link
Collaborator

I think #994 is the more general answer to this - if you could provide the requires and extra_requires as the output of some other rule, then you'd be able to use something like https://docs.aspect.build/rules/aspect_bazel_lib/docs/expand_make_vars/#expand_template to create whatever you want.

@alexeagle alexeagle added the Can Close? Will close in 30 days if there is no new activity label Jan 21, 2023
@jgsogo
Copy link
Author

jgsogo commented Jan 24, 2023

For sure you know better how to fit these feature requests into the codebase (and I agree #994 is more generic and includes this request). 👍

Based on my little experience, I find this one quite straightforward to implement, while #994 is a bit harder. I'm fine closing this one, but I'm not sure if I will have the time to give #994 a try in the following days (I'll try, but I cannot promise, my free time is very scarce now)

@github-actions github-actions bot removed the Can Close? Will close in 30 days if there is no new activity label Jan 24, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

@github-actions github-actions bot added the Can Close? Will close in 30 days if there is no new activity label Jul 23, 2023
@github-actions
Copy link

This issue was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? Will close in 30 days if there is no new activity
Projects
None yet
Development

No branches or pull requests

2 participants