From 8f109c616038075db14a4cc391751daabddccaf6 Mon Sep 17 00:00:00 2001 From: Tobias Slettemoen Kongsvik Date: Tue, 20 Aug 2024 10:04:11 +0200 Subject: [PATCH 1/2] fix: t.Fatal/t.Fatalf typo --- CHANGELOG.md | 3 +++ gazelle/manifest/test/test.go | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1b457c411..42c5bfc89 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,9 @@ A brief description of the categories of changes: ### Changed * Nothing yet +### Fixed +* (gazelle): Fix ncorrect use of `t.Fatal`/`t.Fatalf` in tests. + ### Added * Nothing yet diff --git a/gazelle/manifest/test/test.go b/gazelle/manifest/test/test.go index 506c7d207..a7647f3f7 100644 --- a/gazelle/manifest/test/test.go +++ b/gazelle/manifest/test/test.go @@ -33,12 +33,12 @@ import ( func TestGazelleManifestIsUpdated(t *testing.T) { requirementsPath := os.Getenv("_TEST_REQUIREMENTS") if requirementsPath == "" { - t.Fatalf("_TEST_REQUIREMENTS must be set") + t.Fatal("_TEST_REQUIREMENTS must be set") } manifestPath := os.Getenv("_TEST_MANIFEST") if manifestPath == "" { - t.Fatalf("_TEST_MANIFEST must be set") + t.Fatal("_TEST_MANIFEST must be set") } manifestFile := new(manifest.File) @@ -53,7 +53,7 @@ func TestGazelleManifestIsUpdated(t *testing.T) { manifestGeneratorHashPath, err := runfiles.Rlocation( os.Getenv("_TEST_MANIFEST_GENERATOR_HASH")) if err != nil { - t.Fatal("failed to resolve runfiles path of manifest: %v", err) + t.Fatalf("failed to resolve runfiles path of manifest: %v", err) } manifestGeneratorHash, err := os.Open(manifestGeneratorHashPath) From 26f902e15b076f78e844856f0583fa1b22990aaa Mon Sep 17 00:00:00 2001 From: Tobias Slettemoen Kongsvik Date: Wed, 21 Aug 2024 08:47:25 +0200 Subject: [PATCH 2/2] Update CHANGELOG.md Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 42c5bfc89..91554c498 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,7 +28,7 @@ A brief description of the categories of changes: * Nothing yet ### Fixed -* (gazelle): Fix ncorrect use of `t.Fatal`/`t.Fatalf` in tests. +* (gazelle): Fix incorrect use of `t.Fatal`/`t.Fatalf` in tests. ### Added * Nothing yet