rubocop breaks code when "fixing" attr :name, true

[radiospiel]

Rubocop replaces

attr :name, true

with

attr_reader :name, true

which is plain wrong. If it would replace that line at all, it should use

attr_writer :name

instead.

[jonas054]

There's not much documentation, but it looks like
attr :name, true is equivalent to attr_accessor :name
and
attr :name, false and attr :name are equivalent to attr_reader :name.
So we do have a bug here.

[bbatsov]

Indeed. I had not idea about this behaviour. We should fix this.

[alexdowad]

I see that @weh has created an updated spec... but no code to actually make the spec pass. The two should go together.

[alexdowad]

@weh, would you like to write the code to fix this one?

[weh]

yes, i was searching for a 24pullrequests issue to fix.

[weh]

sorry for the mess with the issue references. lesson learned :)

[bbatsov]

Noticed one more issue in the code. And regarding the commit message - it should not end with . (titles don't have dots in them).

[alexdowad]

@bbatsov, I like your thorough code reviews!