Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offense counts in .rubocop_todo.yml are noisy #2511

Closed
agrimm opened this issue Dec 17, 2015 · 5 comments
Closed

Offense counts in .rubocop_todo.yml are noisy #2511

agrimm opened this issue Dec 17, 2015 · 5 comments

Comments

@agrimm
Copy link
Contributor

agrimm commented Dec 17, 2015

Whenever rubocop --auto-gen-config is rerun, a lot of the changes you can see doing a git diff of the .rubocop_todo.yml are changes to the offense count lines. Usually when I incorporate the changes into git, I do git add -p, commit the relevant changes (such as an offense being squashed for a particular excluded file, or squashed altogether), and then git checkout the offense counts.

Possibilities I can think of:

  • Have an option to not show offense counts.
  • Only display the first significant figure (eg 3 offenses, between 10 and 19 offenses, between 200 and 299 offenses)
  • If a todo file already exists, don't modify the offense count if the change is small (I don't like this option, because it results in behavior that changes depending on whether or not the file exists)
@alexdowad
Copy link
Contributor

If an option was added not to show offense counts, what interface would you propose for that option?

@agrimm
Copy link
Contributor Author

agrimm commented Dec 23, 2015

It'd presumably be a command-line option like --no-offense-counts. RuboCop has recently allowed configuration options to be given along with --auto-gen-config.

@alexdowad
Copy link
Contributor

Maintainers, do you like the idea of --no-offense-counts?

@bbatsov
Copy link
Collaborator

bbatsov commented Dec 23, 2015

That's fine by me.

@alexdowad
Copy link
Contributor

OK, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants