Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make StringLiterals cop configurable #520

Closed
bbatsov opened this issue Sep 28, 2013 · 3 comments
Closed

Make StringLiterals cop configurable #520

bbatsov opened this issue Sep 28, 2013 · 3 comments
Assignees
@jonas054

Comments

@bbatsov
Copy link
Collaborator

bbatsov commented Sep 28, 2013

As with the hash syntax, there's not clear consensus on the subject - some people feel that using double-quotes whenever possible is a better idea. I guess we should support this - in this style we should assume that each string should be using double quotes unless it has escape characters in it or double quotes.
@jonas054
Copy link
Collaborator

👍 Absolutely. Be opinioneted in default choices, but give the people what they want through configuration options.

@bbatsov
Copy link
Collaborator Author

bbatsov commented Sep 29, 2013

Indeed. I'll volunteer you for this task and myself for the hash rockets :-)

@ghost ghost assigned jonas054 Sep 29, 2013
@jonas054
Copy link
Collaborator

😀

bbatsov added a commit that referenced this issue Sep 29, 2013
@bbatsov
Merge pull request #521 from jonas054/configurable_string_literals
70f0e9b 
[Fix #520] Make StringLiterals cop configurable.
@lamont-granquist lamont-granquist mentioned this issue Feb 17, 2015
Closed
@scarver2 scarver2 mentioned this issue Sep 1, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonas054 jonas054

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbatsov @jonas054