add '--failed-level' option #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,6 +30,10 @@ def parse(args) | |||
| require f | |||
| end | |||
|
|
|||
| opts.on('--failed-level N', /[1-5]/, 'Minimum failed level.') do |n| | |||
There was a problem hiding this comment.
I don't think users know what the numbers 1-5 mean. We will have to explain it or let them use initial letters R, C, W, E, F (R for Refactor is not used anywhere).
Also, the explanation could be more clear. Perhaps "Minimum severity for exit with error code." would do.
|
The code looks good to me. I have just a few remarks:
@jonas054 @yujinakayama Anything else you'd like to add? |
| # @return [Symbol] | ||
| # severity. | ||
| # any of `:refactor`, `:convention`, `:warning`, `:error` or `:fatal`. | ||
| attr_reader :key |
There was a problem hiding this comment.
I think the attribute names key and code are a bit ambiguous. I'd suggest name as a replacement for the current key.
👍 Also the commits need to be squashed. |
|
Fixed. |
|
👍 |
|
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is useful to display warning but to make successful build on CI server.