TrivialAccessors accepts DSL-style writers.
#963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe this should be an option. Technically speaking it's still a trivial accessor and most people are unlikely to be creating DSLs, so they should explicitly state their intent. |
|
@bbatsov done |
| @@ -388,6 +388,7 @@ TrailingComma: | |||
| TrivialAccessors: | |||
| ExactNameMatch: false | |||
| AllowPredicates: false | |||
| AllowDSLWriters: false | |||
There was a problem hiding this comment.
You should add a comment for that, as it's not obvious from the name what's the point of the option.
|
The code looks good. Address my minor remarks and rebase on top of the current |
|
ok, this should be good to go |
|
Indeed. Thanks! |
bbatsov
added a commit
that referenced
this pull request
Apr 7, 2014
`TrivialAccessors` accepts DSL-style writers.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bbatsov what do you think of this change?