Fix auto-correct alignment of Style/ParallelAssignment #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrosenblum
force-pushed
the
parallel_assignment_autocorrect_alignment
branch
from
4ba7d7d to
7f81ef1
Compare
| @@ -48,6 +48,7 @@ | |||
| * [#2023](https://github.com/bbatsov/rubocop/issues/2023): Avoid auto-correction corruption in `IndentationWidth`. ([@jonas054][]) | |||
| * [#2080](https://github.com/bbatsov/rubocop/issues/2080): Properly parse code in `Performance/Count` when calling `select..count` in a class that extends an enumerable. ([@rrosenblum][]) | |||
| * [#2093](https://github.com/bbatsov/rubocop/issues/2093): Fix bug in `Style/OneLineConditional` which should not raise an offense with an 'if/then/end' statement. ([@sliuu][]) | |||
| * [#2107](https://github.com/bbatsov/rubocop/pull/2107): Fix auto-correct of `Style/ParallelAssignment` for nested expressions. ([@rrosenblum][]) | |||
There was a problem hiding this comment.
This should be bumped to the master section of the changelog. (I released 0.33 yesterday)
rrosenblum
force-pushed
the
parallel_assignment_autocorrect_alignment
branch
from
7f81ef1 to
13dfd9a
Compare
|
Always happy to have a new version of RuboCop released. I wish there was a better way to handle the changelog when this happens. The code has been rebased. |
bbatsov
added a commit
that referenced
this pull request
Aug 6, 2015
…ect_alignment Fix auto-correct alignment of Style/ParallelAssignment
|
👍 Looks good! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto correct was not properly accounting for the space offset of nested assignment.
I found this while writing auto correct functionality for
Style/RescueModifier(pull request coming shortly). I am going to try to find a more generic way to come up with space offset and indentation for corrections that span multiple lines.