Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude test directories from Documentation cop by default #2258

Merged
merged 1 commit into from
Sep 18, 2015

Conversation

rrosenblum
Copy link
Contributor

The comment from the spec/.rubocop.yml file says it all

# The documentation check doesn't make sense for test code

I think this applies to nearly all projects.

@rrosenblum rrosenblum force-pushed the exclude_tests_from_documentation branch from 3633fea to 41c8afe Compare September 18, 2015 02:08
@@ -2,6 +2,10 @@

## master (unreleased)

### Changes

* [#2258](https://github.com/bbatsov/rubocop/pull/2258): `Style/Documentation` will exclude test directories by default. ([@rrosenblum][])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already a Changes section.

@rrosenblum rrosenblum force-pushed the exclude_tests_from_documentation branch from 41c8afe to 45be530 Compare September 18, 2015 15:48
@rrosenblum
Copy link
Contributor Author

Whoops, I overlooked the other CHANGES section in the CHANGELOG. I have moved my change message.

bbatsov added a commit that referenced this pull request Sep 18, 2015
…tion

Exclude test directories from Documentation cop by default
@bbatsov bbatsov merged commit 9acc967 into rubocop:master Sep 18, 2015
@rrosenblum rrosenblum deleted the exclude_tests_from_documentation branch September 22, 2015 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants