Run RuboCop over its self for the default rake task #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +23,15 @@ task :coverage do | |||
| Rake::Task['spec'].execute | |||
| end | |||
|
|
|||
| task default: :spec | |||
| desc 'Run RuboCop over its self' | |||
| task :inception do | |||
There was a problem hiding this comment.
Already there's Rubocop::RakeTask.
https://github.com/bbatsov/rubocop/blob/503478cf9c07affaebd4c66d04dd4fd7b0449314/README.md#rake-integration
There was a problem hiding this comment.
Oh, perfect! I'll switch it over to that
There was a problem hiding this comment.
Or, maybe not.
It adds a fair bit of load time to the rake file (quarter of a second on my MBP). How perf-sensitive should I be here, @bbatsov? (Though, I suppose the better approach is to optimize the load time of rubocop/rake_task in general, if it's a concern)
There was a problem hiding this comment.
Actually, just committed best of both worlds
bbatsov
added a commit
that referenced
this pull request
Oct 16, 2013
Run RuboCop over its self for the default rake task
|
@nevir Nice solution! |
| @@ -23,7 +24,10 @@ task :coverage do | |||
| Rake::Task['spec'].execute | |||
| end | |||
|
|
|||
| task default: :spec | |||
| desc 'Run RuboCop over its self' | |||
There was a problem hiding this comment.
"its self"? Not "itself"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this'll help a lot for contributors (the current breakage on master, and I ran into it on my other pull requests too) - force us to check style by default :)