Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'hide' option does not hide warnings #303

Closed
jennyrobertsonbbc opened this issue Oct 25, 2019 · 3 comments
Closed

The 'hide' option does not hide warnings #303

jennyrobertsonbbc opened this issue Oct 25, 2019 · 3 comments
Assignees

Comments

@jennyrobertsonbbc
Copy link
Contributor

jennyrobertsonbbc commented Oct 25, 2019

Summary

The 'hide' option does not hide warnings, it only hides failures.

Expected Behaviour

Having something in the 'hide' options would also hide the warnings.

Current Behaviour

'bbccookies-prompt' is in my hide options, but the warning

⚠ Structure: Headings: Headings must be in ascending order - First heading was not a main heading: //div[@id='bbcprivacy-prompt']/h2
is still appearing in my output on the command line.

Possible Solution

Make the addWarning function similar to the addError function:

if (this.hide) {

Steps to Reproduce (for bugs)

  1. Find a warning that is being output BBC a11y and add it to your hide options
  2. Observe that the warning still appears.

Context & Motivation

It will make developers think there is an issue that may need fixing, when actually we don't have control over certain elements, and have hidden them from the a11y tool.

@EmmaJP EmmaJP added the bug label Nov 12, 2019
@EmmaJP
Copy link
Contributor

EmmaJP commented Nov 12, 2019

Agree it should be possible to hide warnings as well as errors, especially for code that the team have no control over.

However, the specific issue around heading hierarchy is also covered by #284

@andymsuk andymsuk added effort-ok seeking-assignee It would be great if someone would pick this up and work on it. labels Nov 13, 2019
@jennyrobertsonbbc
Copy link
Contributor Author

I would like to work on this issue today :)

@EmmaJP EmmaJP removed the seeking-assignee It would be great if someone would pick this up and work on it. label Nov 25, 2019
@jennyrobertsonbbc
Copy link
Contributor Author

A fix for this has now been merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants