This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
bump dependencies to latest #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekp
added
simorgh-core-stream
dependencies
added 2 commits
August 5, 2019 12:21
thekp
requested review from
dr3,
j-pendlebury,
pjlee11 and
sareh
as code owners
RayNjeri
approved these changes
Aug 5, 2019
|
2 vulnerabilities arise from these dependency bumps
|
sareh
approved these changes
Aug 5, 2019
|
Approved pending a separate fix for the vulnerabilities that were introduced here. |
|
Have opened up a PR to fix the vulnerability in |
3 tasks
|
The changes are dev changes by minor bumps doesn't require a testing effort by a tester as long as the tests on CI pass. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: n/a
Overall change: bumping dependencies in the
package.jsonTest notes: all these tests are dev dependencies, if they pass on CI the changes should be fine.
I have bumped the following dependencies: