From 947f6ca92394bcc77adcd273860cc90c81fd177f Mon Sep 17 00:00:00 2001
From: Gerard <gerardlamo@gmail.com>
Date: Mon, 14 Oct 2024 12:20:38 +0200
Subject: [PATCH] Update select to support multiple

---
 .../src/components/BccSelect/BccSelect.css    |  8 +++
 .../components/BccSelect/BccSelect.stories.ts | 52 ++++++++++++++++++-
 .../src/components/BccSelect/BccSelect.vue    | 10 ++--
 3 files changed, 63 insertions(+), 7 deletions(-)

diff --git a/design-library/src/components/BccSelect/BccSelect.css b/design-library/src/components/BccSelect/BccSelect.css
index 2ade6f44..d256758d 100644
--- a/design-library/src/components/BccSelect/BccSelect.css
+++ b/design-library/src/components/BccSelect/BccSelect.css
@@ -19,4 +19,12 @@
     .bcc-select-success {
         @apply border-success focus:outline-success;
     }
+
+    .bcc-select[multiple] {
+        background-image: none;
+        @apply h-auto max-h-full relative p-0 overflow-y-auto;
+    }
+    .bcc-select[multiple]>option {
+        @apply py-2 px-4;
+    }
 }
diff --git a/design-library/src/components/BccSelect/BccSelect.stories.ts b/design-library/src/components/BccSelect/BccSelect.stories.ts
index 30655ffd..29d15244 100644
--- a/design-library/src/components/BccSelect/BccSelect.stories.ts
+++ b/design-library/src/components/BccSelect/BccSelect.stories.ts
@@ -1,3 +1,4 @@
+import { ref } from "vue";
 import BccSelect from "./BccSelect.vue";
 
 import type { Meta, StoryFn } from "@storybook/vue3";
@@ -21,19 +22,24 @@ export default {
     showOptionalLabel: {
       description: "Will only take effect when `required` is `false`",
     },
+    multiple: {
+      control: { type: "boolean", default: false },
+    },
   },
 } as Meta<typeof BccSelect>;
 
 const Template: StoryFn<typeof BccSelect> = (args) => ({
   components: { BccSelect },
   setup() {
-    return { args };
+    const selected = ref([]);
+    return { args, selected };
   },
   template: `
-    <BccSelect v-bind="args" class="w-1/4">
+    <BccSelect v-bind="args" v-model="selected" class="w-1/4">
       <option disabled value="">Select an option...</option>
       <option value="one">Option 1</option>
       <option value="two">Option 2</option>
+      <option value="three">Option 3</option>
     </BccSelect>
   `,
 });
@@ -64,12 +70,38 @@ Example.parameters = {
   <option disabled value="">Select an option...</option>
   <option value="one">Option 1</option>
   <option value="two">Option 2</option>
+  <option value="three">Option 3</option>
 </BccSelect>
 `,
     },
   },
 };
 
+/**
+ * Set the `multiple` prop to allow multiple options to be selected.
+ */
+export const Multiple: StoryFn<typeof BccSelect> = () => ({
+  components: { BccSelect },
+  setup() {
+    const selected = ref([]);
+    return { selected };
+  },
+  template: `
+    <div class="flex flex-col space-y-4">
+      <BccSelect multiple class="w-1/4" v-model="selected">
+        <option disabled value="">Select an option...</option>
+        <option value="one">Success</option>
+        <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
+      </BccSelect>
+
+      <br/>
+      <h3>Selected:</h3>
+      <pre>{{ selected }}</pre>
+    </div>
+  `,
+});
+
 /**
  * Set the `state` prop to control how the select is rendered. Set the `disabled` prop to disable the select
  */
@@ -80,26 +112,32 @@ export const State: StoryFn<typeof BccSelect> = () => ({
       <BccSelect class="w-1/4" value="default">
         <option value="default">Default</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
       <BccSelect class="w-1/4" value="default" disabled>
         <option value="default">Default disabled</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
       <BccSelect state="error" class="w-1/4" value="default">
         <option value="default">Error</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
       <BccSelect state="error" class="w-1/4" value="default" disabled>
         <option value="default">Error disabled</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
       <BccSelect state="success" class="w-1/4" value="default">
         <option value="default">Success</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
       <BccSelect state="success" class="w-1/4" value="default" disabled>
         <option value="default">Success disabled</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
     </div>
   `,
@@ -116,6 +154,7 @@ export const Placeholder: StoryFn<typeof BccSelect> = () => ({
         <option disabled value="">Select an option...</option>
         <option value="one">Success</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
     </div>
   `,
@@ -131,14 +170,17 @@ export const Size: StoryFn<typeof BccSelect> = () => ({
       <BccSelect label="label for sm select" size="sm" class="w-1/4" value="default">
         <option value="default">sm select</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
       <BccSelect label="label for base select" size="base" class="w-1/4" value="default">
         <option value="default">base select</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
       <BccSelect label="label for lg select" size="lg" class="w-1/4" value="default">
         <option value="default">lg select</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
     </div>
   `,
@@ -154,10 +196,12 @@ export const WithLabel: StoryFn<typeof BccSelect> = () => ({
       <BccSelect label="Example Label" size="base" value="default">
         <option value="default">base select</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
       <BccSelect label="Example Label that is really long but should still display"  class="w-1/4" value="default">
         <option value="default">base select</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
     </div>
   `,
@@ -173,21 +217,25 @@ export const Optional: StoryFn<typeof BccSelect> = () => ({
       <BccSelect show-optional-label label="Example Label" class="w-1/4" value="default">
         <option value="default">With label and optional</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
 
       <BccSelect show-optional-label label="Example Label" optionalLabel="Optional label that is pretty long and should truncate" class="w-1/4" value="default">
         <option value="default">Long optional label</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
 
       <BccSelect show-optional-label optionalLabel="Optional label that is pretty long and should truncate" class="w-1/4" value="default">
         <option value="default">Without label</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
 
       <BccSelect show-optional-label label="Pretty long label as well" optionalLabel="Optional label that is pretty long and should truncate" class="w-1/4" value="default">
         <option value="default">Long label and optional label</option>
         <option value="two">Option 2</option>
+        <option value="three">Option 3</option>
       </BccSelect>
     </div>
   `,
diff --git a/design-library/src/components/BccSelect/BccSelect.vue b/design-library/src/components/BccSelect/BccSelect.vue
index 2217743a..0ebc9767 100644
--- a/design-library/src/components/BccSelect/BccSelect.vue
+++ b/design-library/src/components/BccSelect/BccSelect.vue
@@ -12,7 +12,6 @@ import BccFormLabel from "@/components/BccFormLabel/BccFormLabel.vue";
 import BccFormMessage from "@/components/BccFormMessage/BccFormMessage.vue";
 
 type Props = {
-  modelValue?: string;
   state?: "default" | "error" | "success";
   size?: "sm" | "base" | "lg";
   disabled?: boolean;
@@ -20,6 +19,7 @@ type Props = {
   showOptionalLabel?: boolean;
   optionalLabel?: string;
   required?: boolean;
+  multiple?: boolean;
 };
 
 const props = withDefaults(defineProps<Props>(), {
@@ -28,12 +28,12 @@ const props = withDefaults(defineProps<Props>(), {
   disabled: false,
   required: false,
   showOptionalLabel: false,
+  multiple: false,
   optionalLabel: "Optional",
 });
 
 const id = `bcc-input-${useId()}`;
-
-const emit = defineEmits(["update:modelValue"]);
+const modelValue = defineModel<string | string[] | null>({ default: null });
 
 const showOptionalLabel = computed(() => props.showOptionalLabel && !props.required);
 
@@ -60,10 +60,10 @@ const { attrsWithoutStyles } = useAttrsWithoutStyles();
         'bcc-select-lg': size === 'lg',
       }"
       :id="id"
-      :value="modelValue"
       :disabled="disabled"
       :required="required"
-      @input="emit('update:modelValue', ($event.target as HTMLSelectElement).value)"
+      :multiple="multiple"
+      v-model="modelValue"
       v-bind="attrsWithoutStyles"
     >
       <slot />