From 54645522bf61782e9d41f50a469f0ec4679356f5 Mon Sep 17 00:00:00 2001 From: Travis Semple Date: Wed, 29 Nov 2023 13:52:51 -0800 Subject: [PATCH 1/3] Fix rules being changed, when it's on paper --- package-lock.json | 4 ++-- package.json | 2 +- src/store/store.ts | 5 ++--- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/package-lock.json b/package-lock.json index bf9341f1..fcc5a3ee 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "business-edit-ui", - "version": "4.7.11", + "version": "4.7.12", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "business-edit-ui", - "version": "4.7.11", + "version": "4.7.12", "dependencies": { "@babel/compat-data": "^7.21.5", "@bcrs-shared-components/action-chip": "1.1.5", diff --git a/package.json b/package.json index d4bc8770..11237c62 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "business-edit-ui", - "version": "4.7.11", + "version": "4.7.12", "private": true, "appName": "Edit UI", "sbcName": "SBC Common Components", diff --git a/src/store/store.ts b/src/store/store.ts index f06df8c9..23af7b55 100644 --- a/src/store/store.ts +++ b/src/store/store.ts @@ -1297,7 +1297,7 @@ export const useStore = defineStore('store', { hasSpecialResolutionRulesChanged (): boolean { return this.getSpecialResolutionRules?.includedInResolution || this.getSpecialResolutionRules?.key !== - this.getEntitySnapshot?.businessDocuments?.documentsInfo?.certifiedRules?.key + (this.getEntitySnapshot?.businessDocuments?.documentsInfo?.certifiedRules?.key || null) }, // Grab the latest resolution from the entity snapshot. @@ -1328,8 +1328,7 @@ export const useStore = defineStore('store', { this.hasBusinessNameChanged || this.hasAssociationTypeChanged || this.hasSpecialResolutionRulesChanged || - this.hasSpecialResolutionMemorandumChanged) || - this.isCoopCorrectionFiling + this.hasSpecialResolutionMemorandumChanged) }, getNumberOfDirectors (): number { From 641e652c8f793d1903b573c26468f12f771768b0 Mon Sep 17 00:00:00 2001 From: Travis Semple Date: Wed, 29 Nov 2023 13:54:32 -0800 Subject: [PATCH 2/3] Fix bad code --- src/store/store.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/store/store.ts b/src/store/store.ts index 23af7b55..6ac9741d 100644 --- a/src/store/store.ts +++ b/src/store/store.ts @@ -1328,7 +1328,8 @@ export const useStore = defineStore('store', { this.hasBusinessNameChanged || this.hasAssociationTypeChanged || this.hasSpecialResolutionRulesChanged || - this.hasSpecialResolutionMemorandumChanged) + this.hasSpecialResolutionMemorandumChanged) || + this.isCoopCorrectionFiling }, getNumberOfDirectors (): number { From 71b79d113a47c0a58614159002dd394b2f9f6ff3 Mon Sep 17 00:00:00 2001 From: Travis Semple Date: Wed, 29 Nov 2023 14:24:32 -0800 Subject: [PATCH 3/3] add in extra || null --- src/store/store.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/store/store.ts b/src/store/store.ts index 6ac9741d..4eb153d8 100644 --- a/src/store/store.ts +++ b/src/store/store.ts @@ -1296,7 +1296,7 @@ export const useStore = defineStore('store', { hasSpecialResolutionRulesChanged (): boolean { return this.getSpecialResolutionRules?.includedInResolution || - this.getSpecialResolutionRules?.key !== + (this.getSpecialResolutionRules?.key || null) !== (this.getEntitySnapshot?.businessDocuments?.documentsInfo?.certifiedRules?.key || null) },