From 80576c7024d5f7a4f68bb460d6fd139f82a68f4f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9verin=20Beauvais?= Date: Tue, 23 Jul 2024 10:14:45 -0700 Subject: [PATCH] 21977 Handling for new bootstrap filing statuses (#684) * - app version = 7.3.16 - added latestReviewComment property to filing interface - deleted some unused CSS - added pending list toggling from sub-components - added Todo List subtitle for change-requested filings (eg, cont in) - added Todo List default task handling - added Todo List action for change-requests filings (ie, make changes) - added Todo List content (body) for change-requested filings - fixed misc Todo List console log messages - added missing checks for "empty" continuation in - added handling for cont in review fields (submitter, date, comment) - renamed subtitle subcomponents "SubtitleXXX" - added Approved status handling to FilingTemplate.vue - renamed body subcomponents "BodyXXX" - added Rejected status handling to ContinuationIn.vue - added Hide/View Details button to PendingTemplate.vue - updated body in ContinuationIn.vue (pending) - added misc properties to interfaces as needed - updated unit tests * - specifically enable todo list tooltips - specifically enable pending list tooltips - auto-expand Continuation In bootstrap filing - don't show rejected filing details button - added store getter * wip --------- Co-authored-by: Severin Beauvais --- package-lock.json | 4 +- package.json | 2 +- src/App.vue | 3 +- .../Dashboard/FilingHistoryList.vue | 9 - .../FilingHistoryList/FilingTemplate.vue | 23 ++- ...eEffective.vue => BodyFutureEffective.vue} | 4 +- ...ing.vue => BodyFutureEffectivePending.vue} | 4 +- .../filings/AlterationFiling.vue | 24 +-- .../filings/AmalgamationFiling.vue | 24 +-- .../filings/ChangeOfAddress.vue | 8 +- .../filings/ContinuationIn.vue | 80 ++++++-- .../filings/DissolutionVoluntary.vue | 24 +-- .../filings/IncorporationApplication.vue | 24 +-- ...ing.vue => SubtitleCoaFiledAndPending.vue} | 4 +- ...edAndPaid.vue => SubtitleFiledAndPaid.vue} | 6 +- ...id.vue => SubtitleFiledAndPendingPaid.vue} | 6 +- ...id.vue => SubtitleFutureEffectivePaid.vue} | 6 +- .../subtitles/SubtitleRejected.vue | 72 +++++++ src/components/Dashboard/PendingList.vue | 11 +- .../Dashboard/PendingList/PendingTemplate.vue | 43 +++-- .../PendingList/filings/ContinuationIn.vue | 54 +++++- src/components/Dashboard/StaffNotation.vue | 6 - src/components/Dashboard/TodoList.vue | 176 ++++++++++++++---- src/interfaces/api-filing-interface.ts | 3 + src/interfaces/api-task-interface.ts | 3 +- src/interfaces/todo-item-interface.ts | 6 + src/stores/rootStore.ts | 44 +++-- ...ve.spec.ts => BodyFutureEffective.spec.ts} | 14 +- ....ts => BodyFutureEffectivePending.spec.ts} | 14 +- tests/unit/FilingHistoryList1.spec.ts | 77 ++++---- tests/unit/FilingHistoryList2.spec.ts | 12 +- 31 files changed, 538 insertions(+), 252 deletions(-) rename src/components/Dashboard/FilingHistoryList/bodies/{FutureEffective.vue => BodyFutureEffective.vue} (96%) rename src/components/Dashboard/FilingHistoryList/bodies/{FutureEffectivePending.vue => BodyFutureEffectivePending.vue} (95%) rename src/components/Dashboard/FilingHistoryList/subtitles/{CoaFiledAndPending.vue => SubtitleCoaFiledAndPending.vue} (92%) rename src/components/Dashboard/FilingHistoryList/subtitles/{FiledAndPaid.vue => SubtitleFiledAndPaid.vue} (81%) rename src/components/Dashboard/FilingHistoryList/subtitles/{FiledAndPendingPaid.vue => SubtitleFiledAndPendingPaid.vue} (92%) rename src/components/Dashboard/FilingHistoryList/subtitles/{FutureEffectivePaid.vue => SubtitleFutureEffectivePaid.vue} (94%) create mode 100644 src/components/Dashboard/FilingHistoryList/subtitles/SubtitleRejected.vue rename tests/unit/{FutureEffective.spec.ts => BodyFutureEffective.spec.ts} (93%) rename tests/unit/{FutureEffectivePending.spec.ts => BodyFutureEffectivePending.spec.ts} (90%) diff --git a/package-lock.json b/package-lock.json index 76f61fe18..e3b1370a4 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "business-filings-ui", - "version": "7.3.15", + "version": "7.3.16", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "business-filings-ui", - "version": "7.3.15", + "version": "7.3.16", "dependencies": { "@babel/compat-data": "^7.21.5", "@bcrs-shared-components/base-address": "2.0.9", diff --git a/package.json b/package.json index cc52fcc40..9a2ccaf73 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "business-filings-ui", - "version": "7.3.15", + "version": "7.3.16", "private": true, "appName": "Filings UI", "sbcName": "SBC Common Components", diff --git a/src/App.vue b/src/App.vue index de8afc99c..2f86f220c 100644 --- a/src/App.vue +++ b/src/App.vue @@ -751,7 +751,8 @@ export default class App extends Mixins( applicationDate: this.dateToYyyyMmDd(this.apiToDate(header.date)), legalFilings: [header.name], order: data.courtOrder - } + }, + latestReviewComment: header.latestReviewComment } as ApiFilingIF this.setFilings([filingItem]) } diff --git a/src/components/Dashboard/FilingHistoryList.vue b/src/components/Dashboard/FilingHistoryList.vue index 99ea4e7a5..29c227570 100644 --- a/src/components/Dashboard/FilingHistoryList.vue +++ b/src/components/Dashboard/FilingHistoryList.vue @@ -219,19 +219,10 @@ export default class FilingHistoryList extends Mixins(FilingMixin) { max-height: 60rem; } -.filing-history-item { - padding: 1.25rem 1.5rem; - pointer-events: none; // disable expansion generally -} - :deep(.v-expansion-panel-header) { min-height: auto !important; padding: 0; margin-top: 0.25rem; - - .v-expansion-panel-header__icon { - display: none; - } } // specifically enable anchors, buttons, the pending alert icon and tooltips diff --git a/src/components/Dashboard/FilingHistoryList/FilingTemplate.vue b/src/components/Dashboard/FilingHistoryList/FilingTemplate.vue index 0c3274654..c578a6b51 100644 --- a/src/components/Dashboard/FilingHistoryList/FilingTemplate.vue +++ b/src/components/Dashboard/FilingHistoryList/FilingTemplate.vue @@ -13,13 +13,13 @@ - -

Filing Pending

@@ -137,21 +137,21 @@ import { ApiFilingIF } from '@/interfaces' import { EnumUtilities } from '@/services' import { FilingNames } from '@bcrs-shared-components/enums' import { ContactInfo } from '@/components/common' +import { useFilingHistoryListStore } from '@/stores' import DetailsList from './DetailsList.vue' import DocumentsList from './DocumentsList.vue' -import FiledAndPaid from './subtitles/FiledAndPaid.vue' -import FiledAndPendingPaid from './subtitles/FiledAndPendingPaid.vue' import HeaderActions from './HeaderActions.vue' -import { useFilingHistoryListStore } from '@/stores' +import SubtitleFiledAndPaid from './subtitles/SubtitleFiledAndPaid.vue' +import SubtitleFiledAndPendingPaid from './subtitles/SubtitleFiledAndPendingPaid.vue' @Component({ components: { ContactInfo, DetailsList, DocumentsList, - FiledAndPaid, - FiledAndPendingPaid, - HeaderActions + HeaderActions, + SubtitleFiledAndPaid, + SubtitleFiledAndPendingPaid } }) export default class FilingTemplate extends Vue { @@ -165,6 +165,11 @@ export default class FilingTemplate extends Vue { return EnumUtilities.isStatusPaid(this.filing) } + /** Whether this filing is in Approved status. */ + get isStatusApproved (): boolean { + return EnumUtilities.isStatusApproved(this.filing) + } + /** The title of this filing. */ get title (): string { if (EnumUtilities.isTypeAlteration(this.filing)) return FilingNames.ALTERATION diff --git a/src/components/Dashboard/FilingHistoryList/bodies/FutureEffective.vue b/src/components/Dashboard/FilingHistoryList/bodies/BodyFutureEffective.vue similarity index 96% rename from src/components/Dashboard/FilingHistoryList/bodies/FutureEffective.vue rename to src/components/Dashboard/FilingHistoryList/bodies/BodyFutureEffective.vue index 2015ee364..4330aa905 100644 --- a/src/components/Dashboard/FilingHistoryList/bodies/FutureEffective.vue +++ b/src/components/Dashboard/FilingHistoryList/bodies/BodyFutureEffective.vue @@ -1,5 +1,5 @@