From adc607a1a8f79403b96f6903aea7d565d4d8413c Mon Sep 17 00:00:00 2001 From: Stephanie Harrison Date: Thu, 22 Sep 2022 12:13:31 -0700 Subject: [PATCH 1/4] add subtitle to address doctor input --- src/components/AddressDoctorInput.vue | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/components/AddressDoctorInput.vue b/src/components/AddressDoctorInput.vue index 16d1ff6..b875b18 100644 --- a/src/components/AddressDoctorInput.vue +++ b/src/components/AddressDoctorInput.vue @@ -5,6 +5,11 @@
+

+ {{ subtitle }} +

From 21438fe9d87a4fcb0e2f31db38b88113651fd2d8 Mon Sep 17 00:00:00 2001 From: Stephanie Harrison Date: Thu, 22 Sep 2022 13:37:00 -0700 Subject: [PATCH 2/4] add placeholder value to address doctor input component --- src/components/AddressDoctorInput.vue | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/components/AddressDoctorInput.vue b/src/components/AddressDoctorInput.vue index b875b18..ac1c08a 100644 --- a/src/components/AddressDoctorInput.vue +++ b/src/components/AddressDoctorInput.vue @@ -25,6 +25,7 @@ :required="required" :aria-required="required" :data-cy="getCypressValue()" + :placeholder="placeholder" @keydown="inputKeyDownHandler($event)" @input.stop="inputHandler($event)" @blur="handleBlur($event)" @@ -93,6 +94,10 @@ export default { type: String, default: '', }, + placeholder: { + type: String, + default: '', + }, className: { type: String, default: '', From cf313cfb324555c1022fd9a4b3d0144de672b182 Mon Sep 17 00:00:00 2001 From: Stephanie Harrison Date: Thu, 22 Sep 2022 15:06:09 -0700 Subject: [PATCH 3/4] lint changes --- tests/unit/components/AddressDoctorInput.spec.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/unit/components/AddressDoctorInput.spec.js b/tests/unit/components/AddressDoctorInput.spec.js index 0014352..7413da3 100644 --- a/tests/unit/components/AddressDoctorInput.spec.js +++ b/tests/unit/components/AddressDoctorInput.spec.js @@ -535,11 +535,16 @@ describe('AddressDoctorInput getCypressValue()', () => { it('contains cypress Values on the results', () => { const wrapper = mount(Component, { propsData: { - cypressId: 'potato' + cypressId: 'potato', }, data() { return { - data: ['default0', 'default1', 'default2', 'default3'], + data: [ + 'default0', + 'default1', + 'default2', + 'default3', + ], selectedItemIndex: null, }; }, From fe5b4856cd9df3c491f5dd8396e5be06384035e7 Mon Sep 17 00:00:00 2001 From: Stephanie Harrison Date: Fri, 23 Sep 2022 10:39:41 -0700 Subject: [PATCH 4/4] make subtitle rendering conditional --- src/components/AddressDoctorInput.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/AddressDoctorInput.vue b/src/components/AddressDoctorInput.vue index ac1c08a..bd2633f 100644 --- a/src/components/AddressDoctorInput.vue +++ b/src/components/AddressDoctorInput.vue @@ -6,6 +6,7 @@ :for="id" >{{ label }}

{{ subtitle }}