AUTH UI - Improve error message when affiliating an already-affiliated NR

[sienna-oldaccountdontuse]

Description

This issue was reported in ops incident INC0146295.
A client was trying to add an NR to their account, but the following error message would show.
The NR was NOT consumed, it was still in approved status.
Everyone was confused until Sienna remembered that this is a known issue. This error message shows when a client tries to affiliate an NR to their account that has already been affiliated to someone else's account. Because we use the term "Consumed" for actually using the NR in a filing, this message is very confusing.

Good afternoon SBC,

Anna from BENCHMARK LAW CORPORATION has emailed in with a strange error. Their client did a name reservation for a benefit company on their own, now wants the law firm to use it to create her benefit company but it is not allowing them to add it. The error message is saying the name request has been consumed and it has not:

And they would really like to find a way to get it on their account to use it.

Attached are the errors from the client themselves. My theory is the NR is locked to the clients BC Registry Business account, like we would have with actual benefit companies but I have not come across this error before.

If we could please investigate why this error is happening and if it is lock to the client account to find a way to release it so the firm can use it.

Clients account details:

Account Name: BENCHMARK LAW CORPROATION
Account Number: 1716
Linked BC Online Account No: 597329
Prime Contact ID: PA79790

TO DO

Change the error message to the following:

@tlebedovich

The error message should show whenever a client tries to affiliate an NR to their account that is already affiliated to someone else's account.

[forgeuxGH5]

@sienna-blumstengel Hey I remember talking about this exact use case back when we were designing this!

Question - I thought we (Relationships) built the dashboard so it could affiliate a business to multiple accounts - if the same wasn't done for Name Requests we should do that.

I can look at re-wording the dialog though - it would still be applicable if the NR was used to incorporate/register - and it is confusing

[thorwolpert]

I think there might be some flow / race issues to work out if multiple accounts have an NR.
The quick(er) fix for now would be an error message that says it is already owned by another account, and to ask that account to release the name.

[lmcclung]

@thorwolpert @forgeuxGH5 since we already have a work-around (the first account to release the name); then I suggest we focus on fixing the root of the problem - allowing an NR to be affiliated to multiple accounts.

@sienna-blumstengel could you create an NR on one account and then try affiliating it to another test account to verify this is indeed the issue? Can you also communicate to staff this workaround?

@jyoti3286 - can you check with your team if this was a missed requirement? And if so, can you create a ticket? Either your team or SRE team could fix this? not sure when auth stuff transitioning so also copying @jinghualicgi

[thorwolpert]

That'll be a bigger fix, as the downstream apps that consume it in draft, will need to do more checks that another account hasn't used it.
We do some checks, but should add to the integration tests

[thorwolpert]

Or as a 2 stage fix.
Change the error message and roll that in now to stop the calls coming in.
Do the bigger fix and include in an upcoming release

[forgeuxGH5]

Here's some text for the dialogs:

Use case: Name request managed by another account (not consumed)
Title: Name request managed by another account
Body text: This name request is currently associated with a different BC Registries account. A name request can only be managed by one account at a time. If you wish to manage this name request, the account that is currently managing this Name Request must remove it from their Business Registry list.
Button: OK

Use case Name request used (consumed)
Title: Name request used
Body text: This name request has already been used to [incorporate / register] the business [Name of Business] and cannot be added to your list.
Button: OK

[forgeuxGH5]

We should probably have more elegant handling of used name requests (e.g., add the business) but that's a bit more involved and would need a bit more work.

Thinking about the multiple account scenarios a bit, we probably need to look at that more in addition to the things @thorwolpert mentioned, for example, things like receipt and refund handling across accounts.

[seeker25]

This isn't applicable anymore, I think consumed doesn't even show up in the search