Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name Request: Unsupported characters don't display properly (was: Names changes spontaneously) #11483

Closed
lmcclung opened this issue Mar 9, 2022 · 21 comments
Assignees
Labels
bug Something isn't working ENTITY Business Team Name Request NameX NameX and related services proxied via namex

Comments

@lmcclung
Copy link
Contributor

lmcclung commented Mar 9, 2022

For now, let's stick with what works for CRA - ASCII 128.

From Wael... My experience with this issue is straight ASCII, not extended ASCII to 256 just the 128. For example I have seen à (ASCII 194) accepted but not  (ASCII195). Our database isn’t great at accepting French characters either.

Work to be done in Name Request and namex api.

@lmcclung lmcclung added the ENTITY Business Team label Mar 9, 2022
@severinbeauvais severinbeauvais added the bug Something isn't working label Mar 9, 2022
@JohnamLane
Copy link
Collaborator

This will need a dev to review and confirm my understanding is correct, but here is my reply to Jenn from Tuesday when this was reported.

This has been a challenge in NameX since the NRO database does not support these special characters, but the new Name Request application does allow them to be entered. Special characters make it in the UI, then get escaped when they are saved to the NRO database. This escaping process is what turns unsupported characters into weird stuff like squares that you noticed. In moving from Name Request to NRO to NameX and back, sometimes these characters get double escaped.

@severinbeauvais
Copy link
Collaborator

Thanks, John.

Can you (or Jenn) itemize steps to reproduce this, please?

@thorwolpert
Copy link
Collaborator

Same issue as #7957

@JohnamLane
Copy link
Collaborator

@severinbeauvais in Test, I could not reproduce using these characters - ŒÀÂÇÈÉÎÏÙÛÊ, or the Indian character भारत

These were stripped by the UI on blur in Name Request Test so my theory seems to be incorrect.

@JohnamLane
Copy link
Collaborator

@severinbeauvais brain wave: these NRs came from Societes Online (REGI). This UI does not strip special characters, so that's the source of these. This reduces the volume/impact quite a bit. Linda should be able to work with this from here.

@sienna-oldaccountdontuse
Copy link
Contributor

@lmcclung please post example received from staff in a comment here

@JohnamLane
Copy link
Collaborator

These came in as ops tickets earlier in the week. They have been edited since in NameX though. NR 6666746 & NR 9926382 .

@JohnamLane
Copy link
Collaborator

JohnamLane commented Mar 11, 2022

NR 2928549 is a fresh example from test.
input name: भारत INDIAN CHARACTER SOCIETY
result in NameX: À¤­À¤¾À¤°À¤¤ INDIAN CHARACTER SOCIETY

@sienna-blumstengel @lmcclung

@severinbeauvais severinbeauvais changed the title Names changes spontaneously Name Request: Unsupported characters don't display properly (was: Names changes spontaneously) Mar 11, 2022
@lmcclung
Copy link
Contributor Author

@lmcclung to find out from Wael what set we use.

@yuisotozaki
Copy link

yuisotozaki commented Mar 18, 2022

[EDIT] This issue is not with Name Request UI, it's with Societies Online Name Request.

UX considerations:
* If we can say that 99% of the name requests don't run into this problem, we should show an error message under the field at the time we detect characters outside of what we support.
* We have a guide on how to build a name, so we can mention the supported character set there.

@severinbeauvais
Copy link
Collaborator

What would the validation error message be, when the user enters an invalid character? And would it display right away or when the user clicks the action button?

@jdyck-fw jdyck-fw added SRE SRE team task and removed blocked labels Mar 23, 2022
@jdyck-fw jdyck-fw added Name Request NameX NameX and related services proxied via namex labels Mar 23, 2022
@stevenc987 stevenc987 self-assigned this Mar 23, 2022
@stevenc987
Copy link
Collaborator

@lmcclung
Can SRE team start working on this ticket now or we need to wait for UX person to work on this first?

@JohnamLane
Copy link
Collaborator

@lmcclung Concerned that this change appears to be pointing at Name Request. Please see my examples - Name Request strips these characters already - the source of the issue is Societies Online's NR request flow.
@yuisotozaki @stevenc987 @severinbeauvais

@lmcclung
Copy link
Contributor Author

@JohnamLane thanks John. Will redirect this to the Hometeam to investigate.

@yuisotozaki
Copy link

Removed BC Registries NR comment to help with disambiguation of where the issue is.

@lmcclung
Copy link
Contributor Author

Emailed IT OPs on March 23, 2022.

Hello IT Ops,

Could you raise a ticket for the BAs (Darci/Patty/Louise) to investigate name requests using Societies Online?

Staff have reported that when they are examining a name in Namex, occasionally the name choices change spontaneously on their own. John did some initial research and the NRs staff provided came from Societies Online (REGI).

NR 2928549 is a fresh example from test.
input name: भारत INDIAN CHARACTER SOCIETY
result in NameX: À¤¬À¤¾À¤°À¤¤ INDIAN CHARACTER SOCIETY

@lmcclung
Copy link
Contributor Author

No action required at this time. Ideally, hometeam fixes REGI once their upgrade is completed.

@jinghualicgi jinghualicgi removed the SRE SRE team task label Mar 24, 2022
@jinghualicgi
Copy link
Contributor

Remove SRE tag, thanks @lmcclung

@jdyck-fw
Copy link
Collaborator

@lmcclung - To double check that she has flipped this over to the home team

@jdyck-fw jdyck-fw assigned lmcclung and unassigned stevenc987 Mar 28, 2022
@jdyck-fw
Copy link
Collaborator

jdyck-fw commented Apr 4, 2022

With Linda to confirm and close.

@lmcclung
Copy link
Contributor Author

lmcclung commented Apr 4, 2022

updated service now ticket.

@lmcclung lmcclung closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ENTITY Business Team Name Request NameX NameX and related services proxied via namex
Projects
None yet
Development

No branches or pull requests

9 participants