Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Make and Model validation error when resuming draft #17111

Closed
orelbn opened this issue Jul 14, 2023 · 4 comments
Closed

UI - Make and Model validation error when resuming draft #17111

orelbn opened this issue Jul 14, 2023 · 4 comments
Assignees
Labels
Assets bug Something isn't working

Comments

@orelbn
Copy link

orelbn commented Jul 14, 2023

When Resuming an MHR registration draft and entering a make or model.
The exceeds 65 characters error shows up even if the combination of the two fields is not over 65.

image.png

@chdivyareddy
Copy link
Collaborator

Hey @cameron-eyds , the validation is displayed as expected now, but when the draft is saved with the error validation (>65 characters) and by resuming the draft error validation is not displayed until user tries to make some change in the make and model field. Please take a look, thanks!!

Before saving the draft:
image.png

When the draft is resumed:
image.png

@cameron-eyds
Copy link
Collaborator

@chdivyareddy Morning Divya!
I had a look into this and although the field doesn't prompt a validation immediately, it does catch it alongside all other validations (when navigating to review and confirm step).
I think if it allowed this, it would be an issue but follows out current model of validating at the end of the flow.
We don't currently have a precedent to validate every field when resuming a draft.

If there is concern about this, we could further discuss with Melissa and the design team?

@chdivyareddy
Copy link
Collaborator

@cameron-eyds , got it! I think it should be okay for now as long as it is validating when navigating to the Review & Confirm step...will move this along, thank you!!

@cameron-eyds
Copy link
Collaborator

No prob at all, thank you for confirming!

@PCC199 PCC199 closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants