Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coop Corrections - Business rules when changing directors inside of a correction #17346

Closed
danaannab opened this issue Aug 9, 2023 · 9 comments
Labels
Dev Tasks for developers Pay Work for Pay Team

Comments

@danaannab
Copy link
Collaborator

danaannab commented Aug 9, 2023

This is an effort to keep CRS Correction consistent with Entities Corrections.

->UI to introduce a warning text about Director change acceptance or whether the system will ignore the correction

Currently for a LTD correction:
Screenshot 2023-08-10 at 11.17.39 AM.png

Design:
https://preview.uxpin.com/53053d7aeb85fb29915f7afa596429aea4f2a964#/pages/164029564

@danaannab
Copy link
Collaborator Author

danaannab commented Aug 9, 2023

GIVEN that the user has filed a Director correction after the AGM (Annual General Meeting)
WHEN the date of the director change is AFTER the AGM
THEN the system will accept the correction
ELSE If the date of the director change is BEFORE the AGM
THEN the system will not register the correction/change

@danaannab danaannab changed the title Director Change Acceptance Criteria Director Correction Acceptance Criteria Aug 9, 2023
@JohnamLane JohnamLane changed the title Director Correction Acceptance Criteria Coop Corrections - Business rules when changing directors inside of a correction Aug 9, 2023
@JohnamLane
Copy link
Collaborator

Dana, ask Ethan to find the contents of the expected modal/message to include in this ticket.

@PCC199
Copy link
Collaborator

PCC199 commented Aug 10, 2023

@PCC199 PCC199 added Dev Tasks for developers Pay Work for Pay Team labels Aug 10, 2023
@JohnamLane
Copy link
Collaborator

@ethantspitt Can you please work with Dana and the business to define the specific message or validation to show when changes predate AGM.

@ethantspitt
Copy link
Collaborator

Investigated the AGM date UI screens for coops and would hope to get some business requirement regards to:

  • Looking at a Limited company correction for example, the screen does not ask user for input a director change date. Do we need this information for Coop corrections?
  • how are the AGM dates validated currently for coops? ( couldn't find an example in BCROS ) are there any existing error messages?

@ethantspitt
Copy link
Collaborator

Actions for design :

  • Add date selection box for director change
  • Add AGM date field

@JohnamLane
Copy link
Collaborator

For discussion tomorrow in refinement - adding Director Change date means there will be 3 dates tracked for this correction:

  1. Filing date
  2. Effective date
  3. Director change date

Can this be accommodated?
Also, need confirmation on AR vs AGM date - which is tracked for Coops and which date is used as the stop line for changes?

After requirements being final, we must review with Linda.

@danaannab
Copy link
Collaborator Author

danaannab commented Aug 29, 2023

Reviewed with Linda and she recommended following up with Business on whether entering a date and filing the Director Correction without automating the filing process is feasible. The business should be able to decide whether the Director correction is valid or not on a case by case scenario, once the correction is submitted by the end user.

A meeting with @JohnamLane and @ethantspitt will be organised to discuss the implications of simply entering the date and choosing the correction goes through or not. More feedback to be collected on the different scenarios a Director Correction should take place.

@danaannab
Copy link
Collaborator Author

After several discussion with the business and Linda I opened #18571 and we will work from that ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Tasks for developers Pay Work for Pay Team
Projects
None yet
Development

No branches or pull requests

4 participants