UI: Types of Control (Add a beneficial owner)

[steveburtch]

See design ticket: UI Design - Types of Control (Add a beneficial owner) #17959
Part of epic Add/Register a Beneficial Owner #17846
Wireframes link see UI Design - Add new beneficial owner to company information #15925

Wireframe: https://www.figma.com/file/C2ThYIhZSO44dYBVGp8xAj/Register-Beneficial-Owners?type=design&node-id=1601-19&mode=design

Definitions

Registered owner is the person whose is acting as a trustee
Beneficial owner is a person who is a beneficiary of a trust
Indirect control is control of a company or trust that is a beneficial owner

• one person is the registered owner then at least one person is a beneficial owner (beneficiary) are their share totals are the same.

Instructions

Note: the validation check for these two rules will be applied on submit. So they will not be implemented in this ticket.

• if share or votes are entered, you need to check at least one box here.
• if checked, you must enter shares or votes.

Acceptance Criteria

• the three checkboxes (no validation when they are checked)
• each of the "Percent of Shares" and "Percent of Votes" input boxes should accept values from 1 to 100. Invalid inputs should trigger error message immediately.

[patrickpeinanw]

@forgeuxGH5 If someone types "0025" in the Percent of Shares box. This value would pass our validation check. Do we want to leave it as "0025", or it need to be changed to "25" on blur or on submit?

[forgeuxGH5]

@patrickpeinanw I just added the Validation Matrix to the design ticket and updated a typo in one place to reflect the 1 to 100 value requirement.
But the validation is: "Must be a whole number between, and including, 1 and 100" so if they enter "0" as the first character that should trigger the validation because the value can't be "0", also 0025 (and 025) is not a whole number. Also the maximum number of digits is 3.

[patrickpeinanw]

@forgeuxGH5 Hi Scott, here is the temporary url for my pull request: https://bcregistry-btr-dev--pr-61-2r5xu2cr.web.app/ Can you take a look at it?

[gunanagar]

Please find the issue below
1.Accepting starting from "0". eg 01, 002.

Private Zenhub Image

[gunanagar]

@patrickpeinanw . can you please check this issue.
% symbol should be outside the control according to UX design
Private Zenhub Image

Please refer to UX design below
Private Zenhub Image

[gunanagar]

Please look into this issue. @patrickpeinanw

Expected - Check box with the text is missing as per the UX design
Private Zenhub Image
Actual:
Private Zenhub Image

[forgeuxGH5]

@patrickpeinanw @gunanagar ^ the above feature is a separate ticket (#18727) and wasn't included in the estimate for this ticket

[gunanagar]

Tested and looks good.