Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filings UI: finish implementation (AGM Location Change) #18027

Closed
10 tasks done
severinbeauvais opened this issue Sep 29, 2023 · 6 comments
Closed
10 tasks done

Filings UI: finish implementation (AGM Location Change) #18027

severinbeauvais opened this issue Sep 29, 2023 · 6 comments
Assignees
Labels
ENTITY Business Team good first issue Good for newcomers UX Assurance

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Sep 29, 2023

Requirement:

  • The location selected must be outside of BC.

The framework for this filing was implemented in #17937. This ticket is to complete the filing.

  • change FF from enable-agm-location-chg to supported-agm-location-chg-entities
  • enable allowable actions check (remove debugging)
  • update menu tooltip
  • complete sections
  • update fee codes (AGMLC)
  • remove save/resume - Yes
  • update validation
  • implement unit tests
  • add help content
@severinbeauvais severinbeauvais added the ENTITY Business Team label Sep 29, 2023
@Mihai-QuickSilverDev Mihai-QuickSilverDev added the good first issue Good for newcomers label Sep 29, 2023
@severinbeauvais severinbeauvais changed the title Filings UI: filing logic, etc Filings UI: complete implementation Sep 29, 2023
@severinbeauvais severinbeauvais changed the title Filings UI: complete implementation Filings UI: finish implementation (AGM Location Change) Oct 3, 2023
@ketaki-deodhar ketaki-deodhar self-assigned this Oct 4, 2023
@severinbeauvais
Copy link
Collaborator Author

Adding a requirement...

  • change certify date to Pacific Date format with long month
    • yes, this affects all local filings
    • Yui is aware and will communicate this to the other UI designers

From uxpin:
Private Zenhub Image

@ketaki-deodhar
Copy link
Collaborator

Sounds good

@ketaki-deodhar
Copy link
Collaborator

ketaki-deodhar commented Oct 20, 2023

Test notes:-

Temp url - https://business-filings-dev--pr-551-d62ou6sp.web.app/

  • allowable actions as per requirement
  • menu tooltip when item is disabled
  • No Save/ Save and Resume button
  • filing can be completed and can be seen in Filing history list
  • help content (more updates in part 2)
  • UI does not match the UXpin as design changed a bit over the time. These changes are captured in 18161

@yuisotozaki
Copy link

Observations:

  • Business not-in-good-standing is still allowed to select Request AGM Extension.
  • Help expandable UI seems ... buggy; like it's not smooth animation when collapsing like all other filings' help.
  • Cannot test the filing completion as the fields marked required cannot be entered just yet.

@yuisotozaki
Copy link

yuisotozaki commented Oct 23, 2023

@ketaki-deodhar Please transfer the observations to the part 2 of this ticket and move this one to Ready for QA.

@ketaki-deodhar
Copy link
Collaborator

observations added to 18161.
Please see test notes above while testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENTITY Business Team good first issue Good for newcomers UX Assurance
Projects
None yet
Development

No branches or pull requests

5 participants