Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify - Unit Note / Caution Canceled / MHR Table #18041

Closed
LizGovier opened this issue Oct 2, 2023 · 8 comments
Closed

Verify - Unit Note / Caution Canceled / MHR Table #18041

LizGovier opened this issue Oct 2, 2023 · 8 comments

Comments

@LizGovier
Copy link
Collaborator

LizGovier commented Oct 2, 2023

When I cancel a Notice of Caution (CAU, CAUC, CAUE), the cancelled date should say 'N/A' and N/A should appear in black.

Note: When a unit note expires the text should read expired. There is a secondary ticket to update this for expired unit notes.

Private Zenhub Image

@LizGovier LizGovier added Assets bug Something isn't working UX Assurance and removed bug Something isn't working labels Oct 2, 2023
@PCC199
Copy link
Collaborator

PCC199 commented Oct 12, 2023

@mstanton1 mstanton1 changed the title Unit Note / Caution Canceled / MHR Table UI - Unit Note / Caution Canceled / MHR Table Oct 12, 2023
@PCC199 PCC199 changed the title UI - Unit Note / Caution Canceled / MHR Table UI - Unit Note / Caution Cancelled / MHR Table Oct 12, 2023
@mstanton1 mstanton1 changed the title UI - Unit Note / Caution Cancelled / MHR Table UI - Unit Note / Caution Canceled / MHR Table Oct 12, 2023
@mstanton1
Copy link
Collaborator

Parking for now. We do not receive the information to know that the unit note was cancelled so would need additional work for this to be possible. Discussion of an API change would is required.

@doug-lovett
Copy link
Collaborator

@mstanton1 @LizGovier the caution cancelled status in the UI registrations table is not an issue. The API returns 2 special values for the days to expiry:
-9999 (Caution note has been cancelled)
9999 (Continue Caution has no expiry date)

@arlentees arlentees changed the title UI - Unit Note / Caution Canceled / MHR Table Verify - Unit Note / Caution Canceled / MHR Table Apr 18, 2024
@LizGovier LizGovier self-assigned this Apr 18, 2024
@doug-lovett
Copy link
Collaborator

I assume from the comments history that this ticket applies to the UI registration history Days to Expiry column behaviour.
Verified:
DEV 108316 displays "N/A" days to expiry for a cancelled CAU.
DEV 040560 displays "Expired" days to expiry for a expired CAU, CAUC.
DEV 108309 displays "N/A" days to expiry for a cancelled CAUC, CAUE.

@LizGovier
Copy link
Collaborator Author

LizGovier commented Jun 4, 2024

@doug-lovett Yes that is correct and the Registrations you provide look good. RFQA Thank you

@LizGovier LizGovier removed their assignment Jun 5, 2024
@chdivyareddy
Copy link
Collaborator

@LizGovier @doug-lovett , TEST looks good with the days to expiry column in MHR table, but quick question here - in TEST, I created 2 Notice of caution records one after the other to the same registration and cancelled one of the notice of caution which cancelled both of them, is that expected? or should it just cancel one? Please take a look, thanks!

MHR 108162 in TEST: Created 2 records with CAU, CAUC, CAUE and then cancelled one of them:

image.png

image.png

@LizGovier
Copy link
Collaborator Author

Hey @chdivyareddy I was just going through older Unit Note tickets and found that having two CAU's on a home would be a rare edge case. It seems that we ended up moving forward with the rule: Cancelling a CAU/CAUC/CAUE cancels all active CAU/CAUC/CAUE registrations, so I think what we have above is correct. /cc @doug-lovett

Here are the closed tickets for reference
API Ticket #16770 (Cancel caution status and remarks)

API #16831 (Update rule for extend / continue)

@chdivyareddy
Copy link
Collaborator

@LizGovier , thanks for confirming, will move the ticket forward.

@PCC199 PCC199 closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants