Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify - MHR - Home Owners component validations for Registration/Transfers #18070

Open
3 tasks
chdivyareddy opened this issue Oct 3, 2023 · 4 comments
Open
3 tasks
Labels
Assets bug Something isn't working

Comments

@chdivyareddy
Copy link
Collaborator

chdivyareddy commented Oct 3, 2023

See notes from Dima and Tracey in comments

VERIFY

  • In the Transfer due to sale or gift type for Tenants in Common structure, when a user deletes one of the owner in a group and adds a new owner, then the validation "Group cannot have a mix of owner, executor, administrator and bankruptcy trustee roles." is displayed and stops user from navigating to the review screen.

Private Zenhub Image

  • When filing an MH registration, if the home owners table has mix of owners, then the validation is displayed as expected but the stepper is validated with green checkmark.

Private Zenhub Image

  • In the Transfer due to sale or gift type for Tenants in Common structure, when a user adds a new owner to a group, then the validation "Group cannot have a mix of owner, executor, administrator and bankruptcy trustee roles." is displayed in both the groups and stops user from navigating to the review screen.

Private Zenhub Image

@dimak1
Copy link
Collaborator

dimak1 commented Oct 9, 2023

There are a few tickets that address Home Owners' issues (#17034, #17650, #17907). I've added a dependency on one of the. Let's revisit these issues once all of those tickets are done. Thanks!

@tlebedovich
Copy link

Carrying over notes from #17034 - role errors:

dimak1
commented [4 days ago]
I found the reason for this issue: in our logic, we treat OWNER_IND and OWNER_BUS party types as unique roles and show mixed roles error. We check the partType property to determine the uniqueness of owners in the group, since we don't have an explicit 'role' property.

Please confirm that I should update the code to treat OWNER_IND and OWNER_BUS as the same 'role'?

tlebedovich
commented [4 days ago]
I think we will need both the "Role" - aka the four Role radio buttons - Owner / Executor / Administrator / Bankruptcy Trustee

And then we will also need to know if the owner (any role) is a Person or a Business because we now have a design ticket coming up to stop Qualified Suppliers from doing certain transfers where a business is part of an owner group.

So in summary we need to establish the Role (Owner / Executor / Administrator / Bankruptcy Trustee radio button) AND the Party Type (Person or Business).

The mismatched Role error message is based on the "Role" radio buttons .

I assume this will need to be coordinated with the API as well

@mstanton1 mstanton1 changed the title MHR - Home Owners component validations for Registration/Transfers Verify - MHR - Home Owners component validations for Registration/Transfers Oct 10, 2023
@mstanton1
Copy link
Collaborator

The first item may be addressed. To be verified. If the first is addressed this can be readjusted to a 2.

1 similar comment
@mstanton1
Copy link
Collaborator

The first item may be addressed. To be verified. If the first is addressed this can be readjusted to a 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants