Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX - Corp num missing from SP NRs #18205

Closed
severinbeauvais opened this issue Oct 17, 2023 · 3 comments
Closed

HOTFIX - Corp num missing from SP NRs #18205

severinbeauvais opened this issue Oct 17, 2023 · 3 comments
Assignees
Labels
bug Something isn't working ENTITY Business Team Names Team Name Request Name Examination Team Priority1

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Oct 17, 2023

This appears to be for firms only.

When you create a name-change NR (and after entering the FM number), the NR is created with an empty corpnum.

This means the NR cannot be used to change the name of the FM.

This may also be an issue with alteration, restoration and amalgamation NRs. Not an issue with these because we cannot alter or restore a firm, and amalgamation doesn't use corpnum.

@severinbeauvais severinbeauvais added bug Something isn't working ENTITY Business Team Priority1 labels Oct 17, 2023
@severinbeauvais severinbeauvais self-assigned this Oct 17, 2023
@severinbeauvais
Copy link
Collaborator Author

This seems to be OK for BCxxx businesses.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Oct 17, 2023

Test Notes

The root cause was incorrect entity types in a list. I changed the following:

  • SP should actually be FR
  • ULC should actually be UL

I am not certain that the list of entity types is fully correct, but you can test various entity types.

Especially try a name-change NR for the following types:

  • benefit company
  • bc limited company
  • community contribution company
  • cooperative
  • general partnership
  • sole proprietorship
  • unlimited liability company

@severinbeauvais
Copy link
Collaborator Author

@riyazuddinsyed This is a mustfix. Can you test asap please?

Preview URL: https://namerequest-dev--pr-730-cvs5k9nw.web.app/

@severinbeauvais severinbeauvais added the Names Team Name Request Name Examination Team label Oct 17, 2023
@severinbeauvais severinbeauvais changed the title Namerequest UI: corpnum missing from NR HOTFIX - corpnum missing from SP NRs Oct 18, 2023
@severinbeauvais severinbeauvais changed the title HOTFIX - corpnum missing from SP NRs HOTFIX - Corp num missing from SP NRs Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ENTITY Business Team Names Team Name Request Name Examination Team Priority1
Projects
None yet
Development

No branches or pull requests

2 participants