Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filings UI - "Extension Request" sub-component #18273

Closed
9 tasks done
severinbeauvais opened this issue Oct 20, 2023 · 6 comments
Closed
9 tasks done

Filings UI - "Extension Request" sub-component #18273

severinbeauvais opened this issue Oct 20, 2023 · 6 comments
Assignees
Labels

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Oct 20, 2023

  • see UI design and implement accordingly
  • see Mihai's doc on rules/logic
  • accept any input data (props)
  • implement eligibility logic - complete
  • emit updated data object (with entered + computed values) - done by two-way binding
  • emit "is eligible" event? or capture this in data object 0 two-way binding
  • emit "is valid" event
  • this is partly implemented by Filings UI: finish implementation (AGM Extension) #18024
  • implement unit tests with special focus on exercising all the eligibility logic rules
    • add unit tests for new date utilities functions

UXPin: https://preview.uxpin.com/c32b7a6fabe9dea89e09a5ae63323f485a02396c#/pages/164523638/simulate/sitemap

@severinbeauvais severinbeauvais added the ENTITY Business Team label Oct 20, 2023
@severinbeauvais severinbeauvais changed the title Filings UI - About your Extension Request sub-component Filings UI - "About your Extension Request" sub-component Oct 23, 2023
@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Oct 23, 2023

@severinbeauvais severinbeauvais self-assigned this Oct 23, 2023
@severinbeauvais severinbeauvais changed the title Filings UI - "About your Extension Request" sub-component Filings UI - "Extension Request" sub-component Oct 27, 2023
@jdyck-fw
Copy link
Collaborator

jdyck-fw commented Nov 1, 2023

A large number of test companies likely needed to Test this ticket.

@severinbeauvais
Copy link
Collaborator Author

I am assuming this ticket won't be ready to deploy to Test by mid-day today, so I am un-tagging it from Release 19.5a.

@yuisotozaki
Copy link

UI Observations below.

  1. Field labels and fields column width need adjustment
  2. Spacing between radio menu options need adjustment
  3. AGM Year field validation message needs adjustment
  4. Date picker validation triggering event needs adjustment

Private Zenhub Image

@leodube-aot
Copy link
Collaborator

leodube-aot commented Nov 24, 2023

Fixes done, just in review at the moment (also includes the extension expiry range fix from #18558). They can be seen at this temp url for now: https://business-filings-dev--pr-592-xzlfntdt.web.app/BC0871200?accountid=668

Yui, a couple questions for you.

  1. For your 1st observation (field and label column widths) I did the following. Can you double check this is correct?

Private Zenhub Image

  1. Are we using the correct font size for this filling? I was looking at Consent to Continue Out and that filling appears to be using a smaller size for the fields and labels.
  2. Should the label turn red when "File and Pay" is clicked and validation is triggered (like in Consent to Continue Out)?

Private Zenhub Image

  1. Not a question: I'll be adding proper validation to the DatePickers when the user clicks "OK" or "Cancel" in Filings UI: finish implementation (AGM Extension) #18024

@yuisotozaki
Copy link

  1. Looks good! Verified the new spacing is what's in other places.
  2. Looks good!
  3. Only placeholder should turn red. Implementation looks good!
  4. Understood.

Ready for QA when review is completed.

This was referenced Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants