Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Location Change dropdown & Pad Update Component #18314

Closed
7 tasks done
mstanton1 opened this issue Oct 24, 2023 · 13 comments
Closed
7 tasks done

UI - Location Change dropdown & Pad Update Component #18314

mstanton1 opened this issue Oct 24, 2023 · 13 comments

Comments

@mstanton1
Copy link
Collaborator

mstanton1 commented Oct 24, 2023

  • Create a new Location Change component with following 3 select options:

1. Transport Permit

  • Expand to show placeholder for transport permit fields (which will be done in UI - Transport Permit Form #18313) once this dropdown option is selected
  • Update the Fee Summary

2. Transport Permit - Within the same park

  • Update existing location type review component to display park data and allow edit to pad number (see design)
  • Expand to show Pad Update component once this dropdown option is selected

3. Register Location Change

  • Design is pending so just have this a an option without any actions

Other

  • Add unit tests
@dimak1 dimak1 changed the title UI - Use location change dropdown UI - Location Change dropdown & Pad Update Component Oct 24, 2023
@mstanton1
Copy link
Collaborator Author

@dimak1
Copy link
Collaborator

dimak1 commented Jan 9, 2024

@LizGovier
Copy link
Collaborator

@mstanton1 We didn't mention QS in this ticket and I noticed that ticket #18345 doesn't reference the location change dropdown. Should we add it to this ticket? The only difference is that QS don't have access to 'Register Location Change'

@dimak1
Copy link
Collaborator

dimak1 commented Jan 10, 2024

@LizGovier I've implemented QS role for dropdown, based on the design, so the 3rd option will not show.

@LizGovier
Copy link
Collaborator

@mstanton1 please disregard my comment.

@dimak1 Thank you! Just one minor update. When a location type is selected, could you reduce the space between the label and registration type

Current
Screen Shot 2024-01-10 at 12.17.49 PM.png

Expected results
Screen Shot 2024-01-10 at 12.45.05 PM.png

@dimak1
Copy link
Collaborator

dimak1 commented Jan 10, 2024

@LizGovier this is a standard dropdown, I haven't made any changes. Maybe there are some global styles that overwriting it. It looks like the font size is incorrect, rather than spacing. I'll see what i can do.

@LizGovier
Copy link
Collaborator

LizGovier commented Jan 10, 2024

Hey @dimak1 if this is the standard dropdown, let leave it as is. The font size you have is correct, the screenshot I posted is just a little larger.
@chdivyareddy RFQA. Divya, could you also test for QS that 'Register Location Change' is not showing in the dropdown. Thanks!

@dimak1
Copy link
Collaborator

dimak1 commented Jan 11, 2024

@chdivyareddy ready in DEV. Thank you

@chdivyareddy
Copy link
Collaborator

Verified in DEV!

Staff:
image.png

Transport Permit:
image.png

Transport Permit - Moving within the same Manufactured Home Park:
image.png

QS:
image.png

Transport Permit:
image.png

Transport Permit - Moving within the same Manufactured Home Park:
image.png

@tlebedovich
Copy link

@chdivyareddy @dimak1 - I was checking in DEV and I don't see the Change Location Type modal appearing when users swap between different dropdown options - will this be happening in a different ticket?

Screen Shot 2024-01-22 at 2.28.32 PM.png

@chdivyareddy
Copy link
Collaborator

@tlebedovich Ah...the placeholder for the Transport Permit location type was not implemented with this ticket. So I thought this change could be part of #18313
cc @dimak1

@dimak1
Copy link
Collaborator

dimak1 commented Jan 22, 2024

@chdivyareddy which placeholder?

@chdivyareddy
Copy link
Collaborator

chdivyareddy commented Jan 22, 2024

@dimak1 Transport Permit location type (placeholder) was not implemented with this ticket earlier (which was noted in the description of the ticket).

Change location type modal will be handled in 18315.

@PCC199 PCC199 closed this as completed Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants