Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Transport Permits registration table updates #18347

Closed
mstanton1 opened this issue Oct 26, 2023 · 12 comments
Closed

UI - Transport Permits registration table updates #18347

mstanton1 opened this issue Oct 26, 2023 · 12 comments

Comments

@mstanton1
Copy link
Collaborator

mstanton1 commented Oct 26, 2023

  • change color for expiry date text at 2/1/0 days
  • registration type display name
  • PDF linked to output
@dimak1
Copy link
Collaborator

dimak1 commented Feb 2, 2024

Hi @LizGovier,

  1. For expiry days highlighting, we currently show red colour for under 30 days (although the colour
    styling is broken). Are we changing it to show red for 2 days and under for all types, OR we want to limit it to only Transport Permits?
  2. In Figma for this ticket, you mentioned the row dropdown items for Staff and QS. But it is not mentioned in the ticket. Is there another ticket to verify the correct items are shown, or should we add to this ticket?

@dimak1
Copy link
Collaborator

dimak1 commented Feb 3, 2024

@LizGovier updated the styling for the Expiry Days.

Screenshot 2024-02-02 at 19.44.08.png

Screenshot 2024-02-02 at 19.44.42.png

Screenshot 2024-02-02 at 19.44.58.png

Screenshot 2024-02-02 at 19.45.09.png

Screenshot 2024-02-02 at 19.45.21.png

@LizGovier
Copy link
Collaborator

LizGovier commented Feb 5, 2024

@dimak1 If the home is still active after the transport permit, there shouldn't be any updates to the dropdown. If the home is exempt after filing, then we have this ticket for when a home is exempt: 19140


  • The date should say 'Expired' when it hits '0' and in #495057

Screenshot 2024-02-02 at 19.45.09.png

@dimak1
Copy link
Collaborator

dimak1 commented Feb 5, 2024

@LizGovier updated the Expiry label when reached 0 days (build in progress). For the first item ('If the home is still active...'), is there an action item for me to do or just FYI?

@LizGovier
Copy link
Collaborator

@dimak1 Just an FYI

@dimak1
Copy link
Collaborator

dimak1 commented Feb 5, 2024

Thanks @LizGovier, ready for you now (it will show Expired for 0 days): https://bcregistry-assets-dev--pr-1719-rgotrex1.web.app/

@LizGovier
Copy link
Collaborator

Hey @dimak1 Everything looks good and can be moved to RFQA
/cc @saragunnarsson

@LizGovier
Copy link
Collaborator

@dimak1
cc @chdivyareddy

Is there a way to manipulate the days to expire so we can test it in the table? For 2 days, 1 day. I already see examples for expired.

@dimak1
Copy link
Collaborator

dimak1 commented Feb 5, 2024

@LizGovier @chdivyareddy I found this MHR with 2 days to expire. I have not found one with 1 day, but maybe you could wait till tomorrow :)

Screenshot 2024-02-05 at 14.13.51.png

@chdivyareddy
Copy link
Collaborator

@dimak1 , I could only verify the Days to Expiry for Expired and no. of days that expire in more than 2 days. Could not verify for 2 or 1 day expiry period. Looks like the example you provided above is for Notice of Caution (2 days expiry)

Verified the other flows..
image.png

image.png

image.png

@dimak1
Copy link
Collaborator

dimak1 commented Feb 5, 2024

@chdivyareddy the red highlighting for expiry days is updated for all types of registrations, including Transport Permits. 2 days and 1 day will be red, always, for everything. The rest will be grey.

@chdivyareddy
Copy link
Collaborator

@dimak1 Thanks for confirming, I'll move this along.

@PCC199 PCC199 closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants