Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Unit Note Alert bar "undefined" when doing a Sale/Gift after AFFE #18363

Closed
tlebedovich opened this issue Oct 26, 2023 · 8 comments
Closed
Assignees
Labels
Assets bug Something isn't working

Comments

@tlebedovich
Copy link

tlebedovich commented Oct 26, 2023

Dev

MHR 107839

IF I do an AFFE transfer on a home that has an existing Unit Note alert message (ie Notice of Tax Sale)
THEN when I complete the AFFE
THEN return to the MHR Information page to complete the special Sale/Gift after AFFE
THEN the Unit Note Alert bar shows an "undefined" error

before AFFE:
Screen Shot 2023-10-26 at 4 17 20 PM

after AFFE (before Sale/Gift):

Screen Shot 2023-10-26 at 4 09 33 PM

@dimak1
Copy link
Collaborator

dimak1 commented Apr 12, 2024

@chdivyareddy I'm not sure what the expected behaviour is here, but the Notice of Tax Sale alert message is no longer displayed after AFFE was submitted.

Screenshot 2024-04-12 at 15.54.59.png

@chdivyareddy
Copy link
Collaborator

@dimak1 , thank you! I'll look into this.

@chdivyareddy
Copy link
Collaborator

chdivyareddy commented Apr 16, 2024

Hey @LizGovier , Quick question - Should the warning message still appear on the MHR info screen after filing an AFFE and prevent qualified suppliers from making any changes to this home?

Currently, this warning message is being disappeared after AFFE flow is completed in the staff account and QS able to make changes once the sale/gift flow is filed.

Please take a look and let us know any changes are required, thanks!

Current behavior after filing AFFE:
image.png

@LizGovier
Copy link
Collaborator

LizGovier commented Apr 17, 2024

Hey @chdivyareddy @dimak1 @cameron-eyds
Yes, any alert messages should still appear in the Sale and Gift transfer after an AFFE has been filed.

@cameron-eyds
Copy link
Collaborator

@chdivyareddy @LizGovier Just to follow up here, that notice of tax sale alert message depends on the frozenDocumentType of taxn, returned by the api. Each registration only has a singular frozenDocumentType value at any given time, so when an affe is filed, it overrides this.

If we want to handle both scenarios at the same time, we may need an api update to return more than one frozenDocumentType.

@cameron-eyds
Copy link
Collaborator

cameron-eyds commented Apr 17, 2024

So i have to ask, is this a real scenario, filing Transfer to Executors when there is a notice of tax sale etc?
I think in reverse, the unit notes are disabled while frozen due to affe.

Just to add, there is other implications Divya and i have found when filing Affes when there is a notice of tax sale etc.
Just getting a little muddy so we should probably discuss!

@LizGovier
Copy link
Collaborator

LizGovier commented Apr 17, 2024

Hey @cameron-eyds
Thanks for the explanation. Initially I thought it would be an easy fix so was hoping to keep the current rules we have in place, but I don't think it's worth the effort showing the alert messages in the Sale/Gift registration after an AFFE. Reason being:

  • Purpose for the alert is so staff are aware of the unit note that locks a QS, which they will see when completing the AFFE
  • Staff can still file a registration when there is a Unit Note that locks out a QS
  • When staff complete an AFFE and immediately go to the Sale/Gift transfer, the screen is auto scrolls to the Homeowners section so they don't even see the top of the page where the alert bar would be.

As long as the registrations can be filed, I'm fine with moving this along as a non-issue.

@cameron-eyds
Copy link
Collaborator

Ok, sounds good, thank you Liz!

Just wanted to add, once Staff has finalized that Sale or Gift Transfer, the MHR goes back into the frozen state due to the TAXN. So the alert message is then returned once that in progress filing is cleared, as expected.

@PCC199 PCC199 closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants